Wrong output C++ ArrayList

Question

When i make ArrayList with size 5 it gives wrong result but when it becomes bigger than 5 it becomes correct!

#include <iostream>
#include <string>

using namespace std;

class list
{
    typedef int ListElemtype;
private:
    ListElemtype listArray[6];
public:
    bool insert(ListElemtype e)
    {
        if (numberOfElements == 5) //It turns wrong result when ListArray equal 5??
        {
            cout << "Can't do the insertion" << endl;
            return false;
        } //Why it return false? I know why i but = instead of == :D
        else
        {
            listArray[numberOfElements + 1] = e;
            numberOfElements++;
            cout << "Done perfectly!" << numberOfElements << endl;
            return true;
        }
    };

    bool first(ListElemtype &e);
    bool next(ListElemtype &e);
    int numberOfElements;
    int CurrentPosition;

    void LIST ()
    {
        CurrentPosition=-1;
        numberOfElements=0;
        return;
    }
};

int main()
{
    list A;
    A.LIST();
    A.insert(10);
    A.insert(20);
    A.insert(30);
    A.insert(40);
    A.insert(50);
    A.insert(60);
    system("pause");
    return 0;
}

Your indexing is all wrong. your list starts from 1 and not 0 — user245019
– user245019, Commented Apr 30, 2011 at 19:50
I think you might want to pay more attention to your formatting. It's making the code harder to read than no formatting at all... — Matti Virkkunen
– Matti Virkkunen, Commented Apr 30, 2011 at 19:51

Borealid · Accepted Answer · 2011-04-30 19:46:29Z

1

Arrays are indexed from zero, not from one. So listArray[numberOfElements+1]=e; should be listArray[numberOfElements]=e;. The first inserted element goes into listArray[0].

answered Apr 30, 2011 at 19:46

Borealid

99.4k9 gold badges112 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

eslam saad Over a year ago

Yeah thanks! Can you show me what happen when i made it listArray[numberOfElement]=e and make listArray[4] it gives Done Perfectly for all the results!

sahaj · Accepted Answer · 2011-04-30 19:49:00Z

1

Your listArray size is 6 therefore array index would start from 0 till 5. When you have numberOfElements==5 with listArray[numberOfElements + 1] you are trying to store at index 6 which you don't have.

answered Apr 30, 2011 at 19:49

sahaj

8425 silver badges19 bronze badges

Comments

Andy Finkenstadt · Accepted Answer · 2011-04-30 19:48:33Z

0

As you may know, C bases its arrays at 0 and not 1. Thus,

 else { listArray[numberOfElements+1]=e;

writes to the end of the array contained within list A, when numberOfElements is equal to 5 or higher.

answered Apr 30, 2011 at 19:48

Andy Finkenstadt

3,5871 gold badge23 silver badges25 bronze badges

Collectives™ on Stack Overflow

Wrong output C++ ArrayList

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related