I am trying to create buttons in bulk but the command function doesn't want to work

Question

I want to create tkinter buttons in bulk by using a for loop and the exec function but when i set the command it keeps on calling the function for the last piece in my database

for i in FirstFloor:
    exec('room_%d = CreateRoom(FirstFloor[i]["name"])'%index)
    exec('lbl_%d = Button(window, text=FirstFloor[i]["name"], command=lambda: move(FirstFloor[i]["x"], FirstFloor[i]["y"]), bg="light grey")'%index)
    exec('lbl_%d.grid(column=FirstFloor[i]["x"], row=FirstFloor[i]["y"], columnspan=FirstFloor[i]["xspan"], rowspan=FirstFloor[i]["yspan"])'%index)
    if FirstFloor[i]["locked"] == True:
        exec('lbl_%d.config(state="disabled", bg="red")'%index)
    index += 1

When i run this piece of code and click a button no matter which button i press it keeps going to same object

Could you paste your code in the question as a code snippet, as opposed to free text, it will be easier for us to read and interpret. — Mark Stratmann
– Mark Stratmann, Commented Oct 22, 2019 at 17:08
Since you're asking for help debugging, it's worth mentioning that exec() makes debugging more complicated (see stackoverflow.com/questions/1933451/…), so you'll save yourself time/headaches by not using it unless you really have to. — mRotten
– mRotten, Commented Oct 22, 2019 at 17:09
I used exec because i have over 30 objects in FirstFloor and it saves me a lot of time than writing all the variables out — Barty 200YT
– Barty 200YT, Commented Oct 22, 2019 at 17:12
You really shouldn't use exec. It makes the code harder to understand and harder to debug. Just use a dictionary or list to store all of your button references. — Bryan Oakley
– Bryan Oakley, Commented Oct 22, 2019 at 17:49
There is no reason to use exec() unless you know exactly how it works and how to use it I would avoid. It is 100% possible to do this without exec(). — Mike - SMT
– Mike - SMT, Commented Oct 22, 2019 at 18:31

Paul M. · Accepted Answer · 2019-10-22 17:34:54Z

1

Change this:

command=lambda: move(FirstFloor[i]["x"]

to this:

command=lambda i=i: move(FirstFloor[i]["x"]

answered Oct 22, 2019 at 17:34

Paul M.

10.8k2 gold badges11 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mike - SMT · Accepted Answer · 2019-10-22 18:36:26Z

1

You can create buttons in bulk without exec. You can use a list, dict or tuple. I typically use a list.

By using a list we can reference the index to interact with the button.

Example:

import tkinter as tk

root = tk.Tk()
button_list = []


def do_something(some_value):
    print(button_list[some_value]['text'])


for i in range(10):
    button_list.append(tk.Button(root, text='Button {}'.format(i+1), command=lambda i=i: do_something(i)))
    button_list[-1].grid(row=i, column=0)

root.mainloop()

answered Oct 22, 2019 at 18:36

Mike - SMT

15.3k5 gold badges47 silver badges96 bronze badges

1 Comment

Barty 200YT Over a year ago

Thanks for the help but i think exec() is a lot more easier for me to understand so i'll stick with that

Collectives™ on Stack Overflow

I am trying to create buttons in bulk but the command function doesn't want to work

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related