RSpec nested if function

Question

I'm new to RSpec and I'm trying to do testing but I have no idea how to handle nested if. I hope you can help me. Thank you!

array1 = %w[a b]
array2 = %w[aa b c]
@a = if (array1 & array2).any?
       if !array2.include? 'c'
         'yes'
       else
         'no'
            end
     else
       'neither'
     end
puts @a

I would like to develop a basic test for my code using RSpec. My code runs perfectly I just don't know how to write a test.

Can you add some more detail to your question? What behavior are you getting with the above code and what behavior would you like instead? — quicklikerabbit
– quicklikerabbit, Commented Nov 6, 2019 at 19:03
RSpec and Rubocop are two different things. What's your question? What's the problem? — Sebastián Palma
– Sebastián Palma, Commented Nov 6, 2019 at 19:03
It's not clear what you're asking--you don't write a test for standalone code, you write a test for a method. To test you pass all combinations of parameters to exercise the function in question. — Dave Newton
– Dave Newton, Commented Nov 6, 2019 at 19:14
As @Dave advises you need to write your code as a method and then perform tests on the method. For example: def m(arr1, arr2); return 'neither' if (arr1 & arr2).empty?; array2.include?('c') ? 'no' : 'yes'; end. return 'neither' if (arr1 & arr2).empty? is called a guard clause. Its use reduces by one the number of levels of nested conditional statements. array2.include?('c') ? 'no' : 'yes' uses the ternary operator. — Cary Swoveland
– Cary Swoveland, Commented Nov 7, 2019 at 0:13

Cereal · Accepted Answer · 2019-11-06 19:19:17Z

2

You don't need to explicitly test nested if expressions. When you write a test, you're testing the code as a whole. In this case, you have 3 possible routes the code could take, in which case you would write 3 tests.

One test would satisfy (array1 & array2).any? && !array2.include?('c'), the second test would satisfy (array1 & array2).any? && array2.include?('c'), and the third test would satisfy (array1 & array2).empty?

So, for example...


def my_function(array1, array2)
  if (array1 & array2).any?
    if !array2.include? 'c'
      'yes'
    else
      'no'
    end
  else
    'neither'
  end
end

RSpec.describe 'MyFunction' do
  context 'array has c' do
    it 'should return no' do   #
      expect { my_function(['b'], ['b']) }.to eq("no")
    end
  end
end

answered Nov 6, 2019 at 19:19

Cereal

3,8492 gold badges25 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BenKoshy Over a year ago

Perfectly agree: name a function and test on that function.

Ard Enriquez Over a year ago

Thanks for making me understand principle of testing! That's why I don't see any reference regarding on what I want.

Collectives™ on Stack Overflow

RSpec nested if function

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related