Array push not working inside promise then?

Question

All seems to works perfectly except i cant push my value to my array inside the promise all function ?? What am i doing wrong here ?

var reponses = [];

Object.values(thequestion.answers).forEach(item => {
  var mars = item.mars;

  var getFullName = FirebaseRef.child('/users/' + mars + '/fullName').once('value');
  var getAvatar = FirebaseRef.child('/users/' + mars + '/avatar').once('value');
  var getDescription = FirebaseRef.child('/users/' + mars + '/description').once('value');

  // console.log(queries);
  Promise.all([getFullName, getAvatar, getDescription]).then(answer => {
    var oneanswer = {
      answer: item.answer,
    };

    reponses.push(oneanswer);
  });
  console.log('oneanswer', reponses);
});

Have you tried debugger or adding a console.log() directly above the .push() to make sure your promise is entering the .then — Shiny
– Shiny, Commented Nov 17, 2019 at 19:14
When you call console log, responses hasn't been populated yet. If you call it just after push it should include the new value. Is this the problem? — Alvaro
– Alvaro, Commented Nov 17, 2019 at 19:35

felixmosh · Accepted Answer · 2019-11-17 19:37:40Z

1

Pay attention that your console.log is outside of the async flow.

Therefore, you need to move it inside the "then" of the Promise.

var reponses = [];

Object.values(thequestion.answers).forEach(item => {
  var mars = item.mars;

  var getFullName = FirebaseRef.child('/users/' + mars + '/fullName').once('value');
  var getAvatar = FirebaseRef.child('/users/' + mars + '/avatar').once('value');
  var getDescription = FirebaseRef.child('/users/' + mars + '/description').once('value');

  // console.log(queries);
  Promise.all([getFullName, getAvatar, getDescription]).then(answer => {
    var oneanswer = {
      answer: item.answer,
    };

    reponses.push(oneanswer);
    console.log('oneanswer', reponses);
    // -------^
  });
});

answered Nov 17, 2019 at 19:37

felixmosh

35.8k10 gold badges81 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Array push not working inside promise then?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related