Model not binding all properties in Query Parameters .Net Core 3.0 HTTP GET

Question

I'm trying to bind to a complex object via Query Parameters, and I only seem to be binding the first property, and everything else is initialized with defaults (0, null, false, etc. . . ).

The HTTP Request is coming in with all the applicable property names and values. The property names are an exact match. It binds the first property in the query parameters, but not the others. When the request comes in & is replaced with &amps;. From what research I've done online these should be the same in the eyes of the model binder. Here is my current setup

public class MyComplexObject
{
    public string Id { get; set; }
    public int Level { get; set; }
    public Enum MyEnum { get; set; }
}

[HttpGet]
public IActionResult MyAction( [FromQuery] MyComplexObject model)
{
    // stuff done here.  model.Id is set to the correct value, everything
    // else is set to an initialized value based on type. 

    return View("view", model)
}

This is in an MVC .Net Core 3.0 Web Project (not an API).

When I debug on the action and look at this.Request.QueryString It shows "?Id=2100&Level=6&MyEnum=MyEnumValue" So values are being passed in, I just can't get it to bind to the rest of the properties, and it correctly binds the first property in the Query string (Id).

All the sources I can find say this is how I should set up a complex object via QueryParameters, but I can't find anything decisive on if this is broken for .Net Core 3.0, everything I read is for .Net Core 2.2 and earlier, as well as for POST and WebApi's.

Is this possible in .Net 3.0? If so, what am I doing wrong? There are other ways to go about doing this, I can set up route parameters that bind correctly, but I'm going to be doing this a bunch, and I was hoping to just pass in my model and be done with it rather than url/{paramters1}/{parameter2}/...

Edit::

When I open the chrome debugger and click on the Network tag the call looks like so.

{myurl}?Id=2100&Level=6&MyEnum=MyEnumValue so it matches the Request in the debugger.

Edit Part 2:

I'm making the request via a jQuery .load({url}) in the client. I did a hack var url = url.replace('%amp;', '&'); and that solved one of my problems and it correctly bound the property.

Thank you all for the help!

It looks like something is breaking the URL, it defintely shouldn't have & instead of &. That tells the model binder that the property name is amp;Level, which is isn't. Whatever is building the URL and directing the client to make the request is somehow HTML-encoding your values. The problem is before you get to this code. (Note: You can quickly test this by manually entering a corrected URL and seeing how the model binds.) — David
– David, Commented Nov 28, 2019 at 16:13
How did you make the request? It looks like the URL was mangled by the client. Did the client code use HTML encoding on the entire string instead of individual parameters perhaps? — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Nov 28, 2019 at 16:30
For your Question About URL/{parameter1}/... this link may help you learn.microsoft.com/en-us/aspnet/core/fundamentals/… — gandalf
– gandalf, Commented Nov 28, 2019 at 16:32
Ok, it's definitely the &. I'm making the request via a jQuery .load({url}) in the client. I think I can work this through now. — Josie G. Bigler
– Josie G. Bigler, Commented Nov 28, 2019 at 16:35

gandalf · Accepted Answer · 2019-11-28 16:15:07Z

3

public class MyComplexObject
{
[FromQuery(Name = "Id")]
public string Id { get; set; }
[FromQuery(Name = "Level")]
public int Level { get; set; }
[FromQuery(Name = "MyEnum")]
public Enum MyEnum { get; set; }
}

answered Nov 28, 2019 at 16:15

gandalf

4702 gold badges6 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

gandalf Over a year ago

Can you open the network in chrome debugger and add the request to the details please?

Josie G. Bigler Over a year ago

It matches the request in the debugger. I'm thinking it has something to do with &amps;

gandalf Over a year ago

the query should be like this "?Id=2100&Level=6&MyEnum=MyEnumValue" I dont know from where come the 'amp;'

Syscall · Accepted Answer · 2021-03-31 17:46:49Z

0

I was making the request via a jQuery .load({url}) in the client. I did a hack

var url = url.replace('%amp;', '&');

and that solved one of my problems and it correctly bound the property.

edited Mar 31, 2021 at 17:46

Syscall

19.8k10 gold badges44 silver badges60 bronze badges

answered Mar 31, 2021 at 17:42

Josie G. Bigler

3744 silver badges16 bronze badges

Collectives™ on Stack Overflow

Model not binding all properties in Query Parameters .Net Core 3.0 HTTP GET

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related