Weird issue with Laravel relation in foreach loop

Question

I'm currently facing a weird issue with one of my Laravel Models.

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Gallery extends Model
{
    protected $guarded = ['id'];
    protected $with = ['member','photos', 'cover'];

    public function member()
    {
        return $this->hasOne(Member::class, 'id', 'member')->setEagerLoads([]);
    }

    public function cover()
    {
        return $this->hasOne(Photo::class, 'id', 'cover')->setEagerLoads([]);
    }

    public function photos()
    {
        return $this->morphMany('App\Models\Photo', 'photoable')->setEagerLoads([]);
    }
}

If I dump all galleries, each gallery has a cover which is a Instance of App\Models\Photo

$galleries = Gallery::all();
dump($galleries);

This also works with $galleries->toJson() and $galleries->toArray()

However, if I loop over galleries, cover is only an integer.

$galleries = Gallery::all(); 
foreach($galleries as $gallery){
   dump($gallery->cover);  // Integer instead of App\Models\Photo
}

While this returns a App\Models\Member:

$galleries = Gallery::all(); 
foreach($galleries as $gallery){
   dump($gallery->member); //Instance of App\Models\Member
}

Laravel: 6.6.2 PHP: 7.4

You need to combine all answers here to solve this issue. If you change member to member_id, cover to cover_id on your galleries table, you do not need to explicitly set foreign key and local key, and you problem is solved, imo. — user3532758
– user3532758, Commented Dec 9, 2019 at 9:18

IndianCoding · Accepted Answer · 2019-12-09 10:04:08Z

2

Your Gallery model attribute $cover has the same name as relation.

Your model use $cover attribute which have integer value (foreign key to related model).

You could rename column cover for example to cover_id.

edited Dec 9, 2019 at 10:04

answered Dec 9, 2019 at 9:02

IndianCoding

2,6831 gold badge9 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

lagbox Over a year ago

it will always return the attribute not the relationship, regardless of whether it is loaded or not ... getAttribute checks for the attribute before then looking for the relationship

KiprasT · Accepted Answer · 2019-12-09 09:02:50Z

2

Relationship name cannot be the same as the column name in the table. Rename one or the other, would recommend to rename the column to cover_id.

answered Dec 9, 2019 at 9:02

KiprasT

3955 silver badges15 bronze badges

Comments

Dilip Hirapara · Accepted Answer · 2019-12-09 09:20:01Z

0

You passed the wrong place of param in a relationship.

pass it as below.

public function member()
{
    return $this->hasOne(Member::class, 'member','id')->setEagerLoads([]);
}

public function cover()
{
    return $this->hasOne(Photo::class,'cover','id')->setEagerLoads([]);
}

Here example of laravel doc.

return $this->hasOne('App\Phone', 'foreign_key', 'local_key');

edited Dec 9, 2019 at 9:20

answered Dec 9, 2019 at 9:05

Dilip Hirapara

15.4k3 gold badges34 silver badges56 bronze badges

Collectives™ on Stack Overflow

Weird issue with Laravel relation in foreach loop

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related