How do I fix "Missing ; before statement" in a if statement with text

Question

Every time I use text in an if statement it says "Missing ; before statement." My code is

function onEdit() {
var sheet = SpreadsheetApp.getActive().getSheetByName('Class');
var class = sheet.getRange('Traits!L3').getValue();
  if (class == 'Warlock' ) {
    sheet.getRange('A7:D7')breakApart();
    sheet.getRange('A7:D7')mergeAcross();
  } else {
    if (class == 'Fighter') {
      sheet.getRange('A7:D7')breakApart();
      sheet.getRange('A7:B7')mergeAcross();
    } else {
    }

What it does is break and merge cells based on your class (Warlock and Fighter). Traits!L3 is a data validation that lets you choose a class so if you choose warlock, then it merges 4 cells, if not, (unfinished code). How and why does this show up and is there a way to fix it?

It looks like your problem can be completely solved without Google App Scripts, why can't breakApart mergeAcross just be done with regular formulas do they really need to be scripts? — CodeCamper
– CodeCamper, Commented Dec 19, 2019 at 4:33

CodeCamper · Accepted Answer · 2019-12-19 04:35:21Z

3

You forgot a . before breakApart() and mergeAcross()

function onEdit() {
var sheet = SpreadsheetApp.getActive().getSheetByName('Class');
var char_class = sheet.getRange('Traits!L3').getValue();
  if (char_class == 'Warlock' ) {
    sheet.getRange('A7:D7').breakApart();
    sheet.getRange('A7:D7').mergeAcross();
  } else {
    if (char_class == 'Fighter') {
      sheet.getRange('A7:D7').breakApart();
      sheet.getRange('A7:B7').mergeAcross();
    } else {
    }

You should use Data->Named Ranges in google sheets and start naming your cell references then you can call them in code or even formulas by that name.

answered Dec 19, 2019 at 4:35

CodeCamper

7,0148 gold badges49 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

CodeCamper Over a year ago

@HunterLindsey you can always mark as the answer and vote up now or later. Also I recommend not using Google App Scripts and to use built in formulas as much as you can because GAS is slow and unreliable.

CodeCamper Over a year ago

@HunterLindsey Your question is why were you getting a semicolon error and this resolves that issue, as to whether your code works is an entirely different question as I suggested I would ask a new question on how to solve some of your specific problems without GAS because it often is not necessary. Basically from what I see with your code I don't agree with doing it this way (I would just do regular formulas) but that doesn't mean you can't get it working. You should post a link to your sheet otherwise I have no idea what you are even working with.

Cooper Over a year ago

I don't find Google Apps Script slow or unreliable. Personally, I avoid cell functions

CodeCamper Over a year ago

@Cooper onEdit can only run simultaneously twice and then it ignores all other edits, so if you edit too quickly or have too many people editing at once you will not be guaranteed an onEdit execution, also every time you access the spreadsheet to read or write Google specifically says it is slow and you should do it in batches. A cell function is guaranteed to work.

Cooper Over a year ago

Yes. I never use onEdit in any of my projects. It's a recipe for disaster which most new users use it way too much. And I never let multiple user edit directly from spreadsheet, I always force them to work through a webapp or I won't do the project.

|

Collectives™ on Stack Overflow

How do I fix "Missing ; before statement" in a if statement with text

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related