React.useCallback: do I need to pass functions in array of dependencies along with dependencies?

Question

React docs example shows only [a, b] as dependencies. Function doSomething is not passed.

const memoizedCallback = useCallback(
  () => {
    doSomething(a, b);
  },
  [a, b],
);

But later docs reads:

every value referenced inside the callback should also appear in the dependencies array.

My question: do I need to pass doSomething as well?

const memoizedCallback = useCallback(
  () => {
    doSomething(a, b);
  },
  [a, b, doSomething],
);

if doSomething is defined within the component or custom hook, or is passed as a parameter, then yes. If it's defined outside the function scope, then no. — Patrick Roberts
– Patrick Roberts, Commented Dec 19, 2019 at 21:35

VitoMakarevich · Accepted Answer · 2019-12-19 21:59:48Z

4

Technically it's not required if it doesn't change, but it can bring unexpected behavior, so just for simplicity you need to pass all things you used inside if it's declared in component or comes from props. Also if you are using eslint, there is awesome plugin for hooks which is de-facto standard

answered Dec 19, 2019 at 21:59

VitoMakarevich

4552 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

React.useCallback: do I need to pass functions in array of dependencies along with dependencies?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related