Effective Dart warns about avoiding forEach. Use build in for-in instead

Question

Effective Dart warns about avoiding forEach. Use build in for-in instead.

Is there any better way? I want to wait and return.

 List<PromotionModel> allPromotion = //add data from api;

 Future<List<PromotionModel>> filterPromotion() async {
    List<PromotionModel> temp = [];
    if(!check){
      return allPromotion;
    }else{
      await Future.forEach(allPromotion, (v) async {
        if(v.vendoruid == uid){
          temp.add(v);
        }
      });
      return temp;
    }
  }

allPromotion type is function type... -> List<PromotionModel> — BIS Tech
– BIS Tech, Commented Dec 26, 2019 at 3:19
they say about Iterable.forEach not about Future.forEach - btw why do you need Future.forEach in your case? why dont you simply use Iterable.where? — pskink
– pskink, Commented Dec 26, 2019 at 7:05
@pskink I need to wait until loop finished and then I need to return temp. that's why I used. Is there any other way? — BIS Tech
– BIS Tech, Commented Dec 26, 2019 at 7:40

Benjamin · Accepted Answer · 2019-12-26 01:05:28Z

1

Assuming that allPromotion is of Future<List> type, just await the future and loop through the provided list like so:

final list = await allPromotion;
for (var v in list) {
  if (v.vendoruid == uid) {
    temp.add(v);
  }
}
return temp;

answered Dec 26, 2019 at 1:05

Benjamin

6,2215 gold badges28 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

BIS Tech Over a year ago

please check again my question... I forgot to add type of allPromotion

Benjamin Over a year ago

Maybe I'm misunderstanding but allPromotion isn't of Future type so why are you using Future.forEach()?

BIS Tech Over a year ago

otherwise, return an empty value without a complete loop.. isn't it?

Collectives™ on Stack Overflow

Effective Dart warns about avoiding forEach. Use build in for-in instead

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related