C# array available outside function

Question

  private void frmExecute_Load(object sender, EventArgs e)
    {
        string[] data = File.ReadAllLines("c:\\toyotoconsole\\tssetup.txt");

        // Loop through each line, split, add if server
        for (int i = 0; i < data.Length; i++)
        {
                var serverValues = data[i].Split('|');
        }
    }

Okay first C# windows project, which is cool since I have never really touched this beyond the odd debugging foray.

My problem is the array serverValues is built in a function, how do I make this array available for all functions (not sure if using the right term here) in the same form script (probably the wrong word there as well). Is there a public declaration?

Turn local variable serverValues into a field: declare it outside: private string[] serverValues = null; ... private void frmExecute_Load(object sender, EventArgs e) {...serverValues = data[i].Split('|');...} — Dmitrii Bychenko
– Dmitrii Bychenko, Commented Dec 30, 2019 at 7:03
Even though you turn it as a local variable, variable will overwrite everytime, so at last your serverValues will contain only value of data[data.length - 1].Split('|') — Prasad Telkikar
– Prasad Telkikar, Commented Dec 30, 2019 at 7:12

Dmitrii Bychenko · Accepted Answer · 2019-12-30 10:55:39Z

Technically, you should turn local variable serverValues into a field (or property):

  private string[] serverValues = new string[0];

  private void frmExecute_Load(object sender, EventArgs e) {
    ...
    serverValues = data[i].Split('|'); 
    ...
  }

However, as one can see, you rewrite serverValues within the loop; that's why serverValues will contain the last line splitted only. Another issue is mixing Business logic (ServerValues) and UI (form loading).

It seems you want something like this:

using System.Linq;

...

private string[] m_ServerValues = null;

// Pure buiness logic: ServerValues without any UI (form)
public string[] ServerValues {
  get { 
    // If we have the array we return it
    if (m_ServerValues != null)
      return m_ServerValues;

    // otherwise we compute it
    m_ServerValues = File
      .ReadLines("c:\\toyotoconsole\\tssetup.txt")
      .SelectMany(line => line.Split('|'))
      .ToArray();

    // And return it
    return m_ServerValues;
  } 
}

// UI: form loading
private void frmExecute_Load(object sender, EventArgs e) {
  // If you want to prefetch (it's not necessary)
  var values = ServerValues;
}

Shahid Manzoor Bhat · Accepted Answer · 2019-12-30 07:14:37Z

0

// Declare a private property in you class 
private serverValues = Array.Empty<string>();

And then use within any event

private void frmExecute_Load(object sender, EventArgs e)
{
    string[] data = File.ReadAllLines("c:\\toyotoconsole\\tssetup.txt");

    // Loop through each line, split, add if server
    for (int i = 0; i < data.Length; i++)
    {
        serverValues = data[i].Split('|');
    }
}

edited Dec 30, 2019 at 7:14

answered Dec 30, 2019 at 7:12

Shahid Manzoor Bhat

1,3331 gold badge15 silver badges32 bronze badges

2 Comments

Dmitrii Bychenko Over a year ago

private string[] severValues = new string[0];: typo (severValues's type)

Shahid Manzoor Bhat Over a year ago

Thanks @DmitryBychenko, Upvoting your detailed answer

Collectives™ on Stack Overflow

C# array available outside function

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related