Convert foreach to variable assign when returning a Tuple

Question

Using .NET Framework 4.7.2, I have a function that returns a Tuple and the returned values are then passed to another function in a foreach loop:

foreach ((var price, var discount) in Calculator.Compute(period, calculationComponent))
 {
  var rows = CreateCalculationRows(price, discount, otherParameters);
 }

The Compute function is declared as follow:

public static IEnumerable<(Price price, DiscountInfo discount)> Compute(Price price, CalcComponent calcComponent) { 
  ...
}

The code works fine, but I want to remove the foreach loop, since the Calculator.Compute() function, under some specific conditions that are always true in this specific case, returns a single row. I cannot simplify the Compute() return object, because it is used in many other functions.

How do I change the code to remove the foreach, so that the CreateCalculationRows() receives the parameters correctly ?

(Note, you can write var (price, discount) ..., which is slightly shorter) — canton7
– canton7, Commented Jan 13, 2020 at 16:44
You could use First or FirstOrDefault or something, but I think it would be a better idea to create a new method for Compute that only returns a single tuple instead of an IEnumerable to keep your code self-describing. — user12447201
– user12447201, Commented Jan 13, 2020 at 16:59

Jon Skeet · Accepted Answer · 2020-01-13 16:43:47Z

5

I'd expect something like this to work - just taking a single result and deconstructing that:

(var price, var discount) = Calculator.Compute(period, calculationComponent).Single();
var rows = CreateCalculationRows(price, discount, otherParameters);

answered Jan 13, 2020 at 16:43

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Convert foreach to variable assign when returning a Tuple

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related