phpunit - return two objects to next test case

Question

In some places, my phpunit methods have dependency on two classes so I have decided to write a dedicate method which will create an instance of these two classes(which are related to each other) and will pass them to all phpunit methods. I want to do something like below.

public function testGetInstance()  
{  
    $obj1 = new Class1();  
    $obj2 = new Class2();  
    return $obj1, $obj2;  //can i use list  ?  
}    

/**  
*@depends testGetInstance()  
*/  
public function testBothFeatures(Class1 $obj1, Class2 $obj2) //how to pass 2 instances?      
{  
    //Do all operation related to $obj1 and $obj2  
}

How to achieve above case? Is there a better approach for same?

Whether or not there is a "better approach" depends on what you are actually trying to achieve. — David Harkness
– David Harkness, Commented May 18, 2011 at 1:48

edorian · Accepted Answer · 2011-05-17 11:33:15Z

4

The short answer:

@depends only works for one argument so you have to:

return array($obj1, $obj2);

public function testBothFeatures(array $myClasses) {
    $obj1 = $myClasses[0];
    $obj2 = $myClasses[1];
}

Longer answer:

What are you doing there? Are you using one PHPUnit Test Case to test TWO real classes?

If so thats something you should usually avoid. The only exception is that you might be doing an "integration" test that makes sure bigger parts of your code work together, but you should only do that once you have a unit test for every class.

You want to make sure your classes work independed of other parts of your application so you can easily spot what exactly you broke when you change something.

If you have a class that depends on another class then mock out the second class and use that fake object to make sure your "class under test" works correctly.

answered May 17, 2011 at 11:33

edorian

39.1k15 gold badges129 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

David Harkness Over a year ago

A nice shortcut is to use list($obj1, $obj2) = $myClasses;

Berry Langerak · Accepted Answer · 2011-05-17 11:33:09Z

2

This would make more sense, I guess?

return array(
    'obj1' => new Class1( ),
    'obj2' => new Class2( )
);

answered May 17, 2011 at 11:33

Berry Langerak

18.9k5 gold badges49 silver badges62 bronze badges

Collectives™ on Stack Overflow

phpunit - return two objects to next test case

2 Answers 2

Longer answer:

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Longer answer:

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related