How to control the response with the Elasticsearch async api

Question

How can I control the IndexResponse when using the Elasticsearch async api w/ the HighLevelRestClient v7.5?

Maybe I need to mock the Low Level REST Client and use that mock for my High Level REST Client? 🤔

@Test
void whenIndexResponseHasFailuresDoItShouldReturnFalse() {

  // arrange
  var indexResponse = mock(IndexResponse.class);
  when(indexResponse.getResult()).thenReturn(Result.UPDATED);

  var restHighLevelClient = mock(RestHighLevelClient.class);
  when(restHighLevelClient.indexAsync())
      //do something here??

  var indexReqest = new IndexRequest(...);

  //act
  var myHelper = new MyHelper(restHighLevelClient);
  var result = myHelper.doIt(indexReqest)
    .get();

  //assert
  assert(result).isFalse();
}

class MyHelper {

  //injected RestHighLevelClient

  CompletableFuture<Boolean> doIt(Customer customer) {

    var result = new CompletableFuture<Boolean>();
    var indexRequest = new IndexRequest(...);

    restHighLevelClient.indexAsync(indexRequest, RequestOptions.DEFAULT
         , new ActionListener<IndexResponse>() {
      @Override
      public void onResponse(IndexResponse indexResponse) {  //want to control indexResponse
        if (indexResponse.getResult() == Result.UPDATED) {
          result.complete(false);
        } else {
          result.complete(true);
        }
      }

      @Override
      public void onFailure(Exception e) {
        ...
      }
    });

    return result;
  }
}

Update Sample project using Oleg's answer

Refactor your code. You can't unit test if RestHighLevelClient is created in doIt — Oleg
– Oleg, Commented Feb 25, 2020 at 22:57
It’s not, I’ll update my question, it’s injected, good point, thanks 😊 @Oleg — spottedmahn
– spottedmahn, Commented Feb 25, 2020 at 23:16
Feel free to ignore this comment and not answer, it doesn't really matter anyway, I'm just curious; why did you accept my answer but didn't upvote it? — Oleg
– Oleg, Commented Feb 27, 2020 at 1:51
Hi @Oleg - I'm experimenting/researching, I've usually accepted and upvoted. Interesting read. Before I upvoted, in this case, I wanted to research "should I accept and upvote or just accept? what's the 'right' way?" — spottedmahn
– spottedmahn, Commented Feb 27, 2020 at 12:52

spottedmahn · Accepted Answer · 2020-02-29 03:58:33Z

2

Mock RestHighLevelClient then inside indexAsync mock IndexResponse and pass it to the ActionListener.

RestHighLevelClient restHighLevelClient = mock(RestHighLevelClient.class);
when(restHighLevelClient.indexAsync(any(), any(), any())).then(a -> {
    ActionListener<IndexResponse> listener = a.getArgument(2);
    IndexResponse response = mock(IndexResponse.class);
    when(response.getResult()).then(b -> {
        return Result.UPDATED;
    });
    listener.onResponse(response);
    return null;
});
MyHelper myHelper = new MyHelper(restHighLevelClient);
Boolean result = myHelper.doIt(null).get();
assertFalse(result);

Also, configure Mockito to support mocking final methods otherwise a NPE will be thrown when mocking indexAsync.

Option 1

Instead of using the mockito-core artifact, include the mockito-inline artifact in your project

Option 2

Create a file src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker with mock-maker-inline as the content

edited Feb 29, 2020 at 3:58

spottedmahn

16.2k21 gold badges124 silver badges204 bronze badges

answered Feb 26, 2020 at 0:52

Oleg

6,3542 gold badges27 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Murat Kara Over a year ago

restHighLevelClient.indexAsync() is void method. How do you any return ? for Mockito.when()

Oleg Over a year ago

I don't understand. What return?

Murat Kara Over a year ago

Something should "return" in Mockito.when(). Since indexAsync() is void, it doesn't "return" anything. I just asked how this will happen.

Oleg Over a year ago

@MuratKara It's not a problem. stackoverflow.com/a/29556171/1398418

Collectives™ on Stack Overflow

How to control the response with the Elasticsearch async api

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related