powershell script check internet connection then do if else

Question

i wanna do a script which first checks the internet connection and if the computer has internet downloads a file. If the computer has no internet, the shell should write "You are not connected with the internet". The script does not work with

connection test-netconnection www.hawk.de -CommonTCPPort HTTP{}

My script is:

if() {

$client = new-object System.Net.WebClient
$client.Credentials = Get-Credential
$client.DownloadFile(“https://www.mydomain.de/sites/default/files/styles/xs_12col_16_9_retina/public/DSC_6947.JPG”,“C:\Users\Ole\Downloads\Github\bild.JPG”)
}else {
  Write-Host "Could not connect to the Internet."
}
fi

Thanks for your help.

Please be a bit more detailed than "does not work" - what happens? What behavior are you observing? Are any errors thrown? If so, post them here :) Remember, we can't see your screen — Mathias R. Jessen
– Mathias R. Jessen, Commented Mar 9, 2020 at 12:37
fi is not powershell. Your if ends at the last curly brace. — Palle Due
– Palle Due, Commented Mar 9, 2020 at 13:29

Minkus · Accepted Answer · 2021-04-26 17:07:20Z

2

Windows tracks Internet connection status as part of Network Location Awareness; you can check this status using something like this:

If ((Get-NetConnectionProfile).IPv4Connectivity -contains "Internet" -or (Get-NetConnectionProfile).IPv6Connectivity -contains "Internet") {
    # Do something here
}

https://learn.microsoft.com/en-us/windows/win32/winsock/network-location-awareness-service-provider-nla--2

answered Apr 26, 2021 at 17:07

Minkus

5524 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zack A · Accepted Answer · 2020-03-09 13:28:52Z

1

Try this for your if block..

IF (((Test-NetConnection www.site.com -Port 80 -InformationLevel "Detailed").TcpTestSucceeded) -eq $true)

Change the web address to suit obviously...

answered Mar 9, 2020 at 13:28

Zack A

8707 silver badges12 bronze badges

6 Comments

Palle Due Over a year ago

-eq $true is superfluous. TcpTestSucceeded is already a boolean.

Zack A Over a year ago

Maybe - but it makes the code easier for others to read and understand.... IT also allows others to easily change the code/logic if they want something to happen if it fails. So having it there makes the code easier to read, easier to refactor, and easier for those less powershell savvy to understand. Never post shorthand code... Every time you do god kills a puppy.

Palle Due Over a year ago

Then I propose you add another -eq $true to test the truth value of that statement, and another -eq $true to test the truth value of that statement, and another ...

Zack A Over a year ago

There's only one statement bro... Do you want something to happen if it's true or if it's false? You can easily change the true to a false in either case based on desired results. What I posted solves the OP's question with an easy to read, simple and flexible code block. You're nitpicking because maybe my code doesn't exactly look like what you would have written. That's fine, but it adds nothing to the conversation.

Palle Due Over a year ago

If voted up the answer because it is correct. But to me if (x.TcpTestSucceeded) reads as normal English, whereas if (x.TcpTestSucceeded) -eq $true doesn't. I don't ask my children "Have you done your homework -eq $true?".

|

avarice · Accepted Answer · 2020-03-09 16:21:07Z

0

You can use try..catch block for this:

try {
  $client = new-object System.Net.WebClient $client.Credentials = Get-Credential $client.DownloadFile(“https://www.mydomain.de/sites/default/files/styles/xs_12col_16_9_retina/public/DSC_6947.JPG”,“C:\Users\Ole\Downloads\Github\bild.JPG”) 
}
catch {
  write-host "Not connected to the internet"
}

if..fi syntax refers to bash that's not powershell. Try..Catch is used to handle exceptions and errors.

answered Mar 9, 2020 at 16:21

avarice

15.6k3 gold badges19 silver badges38 bronze badges

Collectives™ on Stack Overflow

powershell script check internet connection then do if else

3 Answers 3

Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related