Why does array.sort not work by an array like this?

Question

I've just started programming around 2 weeks ago so please don't be too strict :)

I tried to solve a programming exercise to print the 3 largest elememts of an Array but the .sort Method

reports an error and I don't know why. It seems like I have declared my Array in the wrong way but I can't spot the mistake.

public static void main(String[] args) {
    int [] elements = {1, 4, 17, 7, 25, 3, 100};
    int k = 3;
    System.out.println("Original Array: ");
    System.out.println(Arrays.toString(elements));
    System.out.println(k +" largest elements of the said array are:");
    Arrays.sort(elements, Collections.reverseOrder());         
   for (int i = 0; i < k; i++) 
      System.out.print(elements[i] + " ");
}

}

Sort arrays of primitive types in descending order

001
– 001

2020-03-11 17:33:35 +00:00
Commented Mar 11, 2020 at 17:33 — 001
– 001, Commented Mar 11, 2020 at 17:33

Jason · Accepted Answer · 2020-03-11 17:47:32Z

5

Because the integers are unboxed and are not objects. They need to be boxed, i.e Integer.

Unboxed

int [] elements = {1, 4, 17, 7, 25, 3, 100};

Boxed

Integer [] elements = {1, 4, 17, 7, 25, 3, 100};

Using Java 8 Streams

       int[] elements = { 1, 4, 17, 7, 25, 3, 100 };

       int[] sortedUnboxed = IntStream.of(elements)
                .boxed()
                .sorted(Comparator.reverseOrder())
                .mapToInt(value -> value)
                .toArray();

        Integer[] sortedBoxed = IntStream.of(elements)
                .boxed()
                .sorted(Comparator.reverseOrder())
                .toArray(Integer[]::new);

edited Mar 11, 2020 at 17:47

answered Mar 11, 2020 at 17:31

Jason

5,2442 gold badges15 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Piyush Maheswari · Accepted Answer · 2020-03-11 17:33:23Z

4

int[] as Collections.reverseOrder doesn't work for primitive types. Please use Integer instead. It will solve the issue.

answered Mar 11, 2020 at 17:33

Piyush Maheswari

6443 silver badges19 bronze badges

Comments

Nexevis · Accepted Answer · 2020-03-11 17:51:34Z

1

The other answers addressed on how to reverse your primitive int array, but according to your problem question, it seems you do not need to reverse the array at all.

Simply iterate through your array beginning at the end by changing your for conditions:

public static void main(String[] args)
{
    int [] elements = {1, 4, 17, 7, 25, 3, 100};
    int k = 3;
    System.out.println("Original Array: ");
    System.out.println(Arrays.toString(elements));
    System.out.println(k +" largest elements of the said array are:");
    Arrays.sort(elements);         
    for (int i = elements.length - 1; i > elements.length - k; i--) 
      System.out.print(elements[i] + " ");
}

Output:

Original Array: 
[1, 4, 17, 7, 25, 3, 100]
3 largest elements of the said array are:
100 25 17

edited Mar 11, 2020 at 17:51

answered Mar 11, 2020 at 17:40

Nexevis

4,7173 gold badges16 silver badges24 bronze badges

Comments

Lajos Arpad · Accepted Answer · 2020-03-11 17:40:05Z

1

Look at the definition of reverseOrder: https://www.javatpoint.com/java-collections-reverseorder-method

It will tell you that it looks like this:

public static <T> Comparator<T> reverseOrder()

the <T> is the generic template. Primitives cannot be used as generic types, see Why don't Java Generics support primitive types?

int is primitive type. Luckily Integer is a wrapper class around int and you can use it as generic. The rest is homework for the student.

I feel your pain that int cannot be a generic, but it is how it is.

answered Mar 11, 2020 at 17:40

Lajos Arpad

80.5k42 gold badges124 silver badges235 bronze badges

Comments

MrsNickalo · Accepted Answer · 2020-03-11 17:42:04Z

1

If you wanted to stick with int, just sort it and print out the last three:

public static void main(String[] args) 
{
    int [] elements = {1, 4, 17, 7, 25, 3, 100};
    int k = 3;
    System.out.println("Original Array: ");
    System.out.println(Arrays.toString(elements));
    System.out.println(k +" largest elements of the said array are:");
    Arrays.sort(elements);         
    for (int i = 0; i < 3; i++) 
      System.out.print(elements[elements.length - 1 - i] + " ");
}

answered Mar 11, 2020 at 17:42

MrsNickalo

2171 silver badge6 bronze badges

Collectives™ on Stack Overflow

Why does array.sort not work by an array like this?

5 Answers 5

Using Java 8 Streams

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Using Java 8 Streams

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related