C# Treeview checking if node exists

Question

I'm trying to populate a treeview from an XmlDocument. The Root of the tree is set as 'Scripts' and from the root the next level should be 'Departments' which is within the XML script. I can get data from the XML document no problem. My question is when looping through the XmlDocument and adding nodes to the root node, I want to ensure that if a department is already within the treeview then it is not added again. I should also add that each Department also has a list of scripts that need to be child nodes of the department.

My code so far is:

        XmlDocument xDoc = new XmlDocument();
        xDoc.LoadXml(scriptInformation);
        TreeNode t1;
        TreeNode rootNode = new TreeNode("Script View");
        treeView1.Nodes.Add(rootNode);
        foreach (XmlNode node in xDoc.SelectNodes("//row"))
        {
            t1 = new TreeNode(node["DEPARTMENT"].InnerXml);
           //How to check if node already exists in treeview?



        }

Thanks.

Vale · Accepted Answer · 2011-05-23 12:54:16Z

3

if(treeView1.Nodes.ContainsKey("DEPARTMENT")){
//...
}

EDIT: Recursive method:

 bool exists = false;
        foreach (TreeNode node in treeView1.Nodes) {
            if (NodeExists(node, "DEPARTMENT"))
                exists = true;
        }
    private bool NodeExists(TreeNode node, string key) {
        foreach (TreeNode subNode in node.Nodes) {
            if (subNode.Text == key) {
                return true;
            }
            if (node.Nodes.Count > 0) {
                NodeExists(node, key);
            }
        }
        return false;
    }

edited May 23, 2011 at 12:54

answered May 23, 2011 at 12:28

Vale

3,2982 gold badges29 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Yuck Over a year ago

I don't believe this is fully recursive. In effect, it will only search immediate child nodes.

Vale Over a year ago

In that case recursive method can be easily created.

Akvel Over a year ago

if (subNode.Text.Equals(key)) { return subNode; } if (subNode.Nodes.Count > 0) { NodeExists(subNode, key); }

Yuck · Accepted Answer · 2011-05-23 12:30:20Z

1

Depending upon the size of your XML file, you could consider using an associated List for fast lookup. As you add each node to the TreeView also add it to the List.

answered May 23, 2011 at 12:30

Yuck

51.1k13 gold badges108 silver badges136 bronze badges

Comments

David Anderson · Accepted Answer · 2011-05-23 12:31:16Z

If your XML document has a set structure where 'Departments' will always be indexed at 1;

ie:

index:[0] Scripts
    index:[1] Department
        index:[2] Script
    index:[1] Department2
        index:[2] Script

Then you could encapsulate the following code into a method where 'name' is a string parameter and the return type is boolean.

foreach (TreeNode node in uxTreeView.Nodes[0].Nodes) {
    if (node.Name.ToLower() == name.ToLower()) {
        return true;
    }
}
return false;

The idea is you would call that function each time you encounter a 'Department' node in your Xml, before creating the TreeNode.

Full example:

private bool DepartmentNodeExists(string name) {
    foreach (TreeNode node in uxTreeView.Nodes[0].Nodes) {
        if (node.Name.ToLower() == name.ToLower()) {
            return true;
        }
    }
    return false;
}

Lastly, the easy way:

private bool DepartmentNodeExists(string name) {
    if (uxTreeView.Nodes[0].ContainsKey(name)) {
        return true;
    }
    else {
        return false;
    }
}

These are all just refactored and encapsulated into their own named methods, you of course could just call:

if (uxTreeView.Nodes[0].ContainsKey(name)) {
    // do not create TreeNode
}

...during your parsing of your XML. PS. These examples all assume that you have the first root node in the TreeView already created and added to the TreeView.

vasmay · Accepted Answer · 2011-05-23 12:33:34Z

1

http://www.vbdotnetforums.com/listviews-treeviews/13278-treeview-search.html#post39625

http://forums.asp.net/t/1645725.aspx/1?Check+if+child+Node+exists+on+treeview

answered May 23, 2011 at 12:33

vasmay

1,4293 gold badges13 silver badges18 bronze badges

Comments

Alex Mendez · Accepted Answer · 2011-05-23 12:39:19Z

1

You can do something like this:

TreeNode parentNode = t1.Parent;
if (parentNode != null}
{
    if(parentNode.Nodes.Cast<TreeNode>().ToList().Find(t => t.Text.Equals(node["DEPARTMENT"].InnerXml) == null)
    {
        //Add node
    }
}
else
{
    bool isFound = true;
    if (treeView1.Nodes.Cast<TreeNode>().ToList().Find(t => t.Text.Equals(node["DEPARTMENT"].InnerXml) == null)
    {
        isFound = false;
    }

    if(!isFound)
    {
        //Add node
    }
}

edited May 23, 2011 at 12:39

answered May 23, 2011 at 12:30

Alex Mendez

5,1501 gold badge27 silver badges23 bronze badges

Comments

Vijay Sirigiri · Accepted Answer · 2011-05-23 14:52:59Z

Not sure about the document structure...
Couldn't you use Linq to Xml, load the document and get the distinct row ( row = department?) and consider only those elements to create a TreeNode? It is more efficient than trying to find if a node with such a text has already been added. ex:

 var rows =      (  from row  in XDocument.Load(document).Root.Elements("row")
                    select row
                 ).Distinct(new SampleElementComparerOnNameAttribute());

Here the EqualityComparer is made on the "name" attribute value assuming the doc structure to be

<rows><row name='dep1'><script>script1</script><script>script2</script></row><row name='dep1'><script>script3</script><script>script4</script></row></rows>

Chuck Savage · Accepted Answer · 2011-05-25 07:45:10Z

1

I use,

string department = node["DEPARTMENT"].InnerXml;
TreeNode node = parentNode.Nodes[department] ?? parentNode.Nodes.Add(department, department);

That line guarantees that a lookup of the value department will be done first, if not found it creates it. You have to do the double entry in Add() so it will have a key value you can do the lookup with the .Nodes[department].

edited May 25, 2011 at 7:45

answered May 25, 2011 at 7:40

Chuck Savage

12k6 gold badges53 silver badges69 bronze badges

Comments

takrl · Accepted Answer · 2011-05-23 12:30:38Z

0

It depends on the structure of your input. Since you don't show how exactly you add your subnodes I can only point you towards either the Contains or the ContainsKey method of the Nodes property, either of the treeView1 itself, or of any subnodes you add. You should use an overload of the Add method to specify a key name to simplify lookup.

edited May 23, 2011 at 12:30

answered May 23, 2011 at 12:25

takrl

6,5003 gold badges64 silver badges71 bronze badges

Collectives™ on Stack Overflow

C# Treeview checking if node exists

8 Answers 8

3 Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

3 Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related