MySQL Node JS DELETE no working - 0 rows affected

Question

I am trying to create a post route that will delete a user's data from several tables. I checked in mySQL workbench that the database user has this privilege. However when I click delete on the frontend, the queries appear to run but the rows do not get deleted. Can you someone please tell me where I am going wrong?

app.post('/disposal', redirectLogin, async(req, res) => {
      const user = res.locals;
      userStmt = `DELETE FROM users WHERE user_name ='${user.user_name}'`;
      cashStmt = `DELETE FROM CASH WHERE user_name ='${user.user_name}'`;
      tradesStmt = `DELETE FROM trades WHERE user_name ='${user.user_name}'`;
      holdingsStmt = `DELETE FROM trades WHERE user_name ='${user.user_name}'`;
      await connection.query(userStmt, (err, results) => {
        if (err) throw err;
        console.log(results);
        connection.query(holdingsStmt, (err, results) => {
          if (err) throw err;
          console.log(results);
          connection.query(cashStmt, (err, results) => {
            if (err) throw err;
            console.log(results);
          });
          connection.query(tradesStmt, (err, results) => {
            if (err) throw err;
            console.log(results);
          });
        });
      });
      req.session.destroy(err => {
        if (err) {
          return res.redirect("/dashboard");
        }
        res.clearCookie(SESS_NAME);
        res.send("Ninja disposed!");
      })
    })

Keenan Mapp · Accepted Answer · 2020-04-15 04:14:21Z

1

I needed to change user = res.locals to { user } = res.locals as it the former was coming back 'undefined' as it was not properly extracting.

answered Apr 15, 2020 at 4:14

Keenan Mapp

691 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sohail Ashraf · Accepted Answer · 2020-04-15 04:17:55Z

0

You don't need to nest the calls if you are using async/await. As the res.locals is an object which contains the user property, you have to get the user property.

You could get it by using Object destructuring syntax.

Try this.

app.post('/disposal', redirectLogin, async (req, res) => {
    const { user } = res.locals;
    userStmt = `DELETE FROM users WHERE user_name ='${user.user_name}'`;
    cashStmt = `DELETE FROM CASH WHERE user_name ='${user.user_name}'`;
    tradesStmt = `DELETE FROM trades WHERE user_name ='${user.user_name}'`;
    holdingsStmt = `DELETE FROM trades WHERE user_name ='${user.user_name}'`;
    try {
        let results = await connection.query(userStmt);
        console.log(results);
        let holdinResult = await connection.query(holdingsStmt);
        console.log(holdinResult);
        let cashResult = await connection.query(cashStmt);
        console.log(cashResult);
        let tradesResult = await connection.query(tradesStmt);
        console.log(tradesResult);
    } catch (error) {
        throw error
    }
    req.session.destroy(err => {
        if (err) {
            return res.redirect("/dashboard");
        }
        res.clearCookie(SESS_NAME);
        res.send("Ninja disposed!");
    })
})

edited Apr 15, 2020 at 4:17

answered Apr 15, 2020 at 3:54

Sohail Ashraf

10.7k3 gold badges31 silver badges43 bronze badges

1 Comment

Keenan Mapp Over a year ago

Alright tried that at first and it still ran with no errors but the log showed me as user_name = undefined. So I changed user = res.locals to {user} = res.locals so that it can be extracted properly. Now it works.

Collectives™ on Stack Overflow

MySQL Node JS DELETE no working - 0 rows affected

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related