Is there something wrong with my For loop?

Question

I am trying to run a GET request to an API that returns JSON. The JSON response looks something like this:

{
    "nodes": [
        {
            "id": "5C73B00598",
            "connectionState": "connected",
            "model": "PP152X"
        },
        {
            "id": "5C73B0059E",
            "connectionState": "connected",
            "model": "PP152X"
        },
        {
            "id": "4C72D012D8",
            "connectionState": "connected",
            "model": "PP203X"
        },
        {
            "id": "5C73B005DE",
            "connectionState": "connected",
            "model": "PP152X"
        },
        {
            "id": "5C73B005A2",
            "connectionState": "connected",
            "model": "PP152X"
        },
        {
            "id": "5C73B004A2",
            "connectionState": "disconnected",
            "model": "PP152X"
        },
        {
            "id": "5C73B0058B",
            "connectionState": "connected",
            "model": "PP152X"
        }
    ]
}

The simplified version of the script to just return one response from one API folder is this so far:

import requests
import json


url = "https://myurl.io/api/Customers/xxx/locations/xxx/nodes"

payload = {}
headers = {
  'Content-Type': 'application/x-www-form-urlencoded',
  'Authorization': 'xxx'
}

response = requests.request("GET", url, headers=headers, data = payload)
str = response.text.strip()



json_str = json.loads(str)
print(len(json_str['nodes']))
i = 0
while i <= len(json_str['nodes']):
    #cus_list = json_str['nodes'][i]['connectionState']
    #cus_lists.append(cus_list)
    print(json_str['nodes'][i]['connectionState'])
    i += 1

When I run this script the while loop does not return 7 iterations of the 'connectionState' but rather just the first one.

Doesn't answer your question but the condition in your while loop should use <. Also paste the actual output of that print statement and the response, not a truncated version of the output. — Victor
– Victor, Commented Apr 16, 2020 at 10:18
the condition aside, the loop seems fine. Are you sure it's returning 7 and not 1 from the api response? — darkash
– darkash, Commented Apr 16, 2020 at 10:27

Joshua Varghese · Accepted Answer · 2020-04-16 10:20:55Z

2

Try:

for i in json_str['nodes']:
    print(i['connectionState'])

This gives:

connected
connected
connected
connected
connected
disconnected
connected

answered Apr 16, 2020 at 10:20

Joshua Varghese

5,2121 gold badge18 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mace · Accepted Answer · 2020-04-16 10:25:10Z

0

i must always be smaller then the len()

json_str = json.loads(str)
print(len(json_str['nodes']))
i = 0
while i < len(json_str['nodes']):
    #cus_list = json_str['nodes'][i]['connectionState']
    #cus_lists.append(cus_list)
    print(json_str['nodes'][i]['connectionState'])
    i += 1

answered Apr 16, 2020 at 10:25

Mace

1,51011 silver badges15 bronze badges

Collectives™ on Stack Overflow

Is there something wrong with my For loop?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related