Why can't I set my javascript variable to false?

Question

For some reason, my articleExists variable will not set to true on line 6, despite me using console logs to confirm that the if statement that it's contained in is triggering properly.

app.post("/articles", function(req, res) {
  let articleExists = (false);
  Article.find(function(err, results) {
    results.forEach(function(result) {
      if (result.title === req.body.title) {
        articleExists = (true);
      }
    });
  });
  if (articleExists) {
    res.send("Article already exists!")
  } else {
    const newArticle = new Article({
      title: req.body.title,
      content: req.body.content
    });
    newArticle.save(function(err) {
      if (err) {
        res.send(err);
      } else {
        res.send("Article saved successfuly")
      }
    });
  }
});

Is the function passed to Article.find(..) executed async ? — Titus
– Titus, Commented Apr 23, 2020 at 17:27

catastrophic error · Accepted Answer · 2020-04-23 18:30:14Z

1

I believe this situation is probably caused by a misunderstanding regarding nodejs async nature.

I recommend you looking a bit into Promises and Async/Await, available at current nodejs versions, which made the code much cleaner and easier to understand.

This article seems to explain it pretty well: https://codeburst.io/javascript-es-2017-learn-async-await-by-example-48acc58bad65

Regarding your issue, here it goes an untested and not elegant solution, hope it helps you:

app.post("/articles", async (req, res) => {
    const results = await Article.find(query);
    const articleExists = results.some(result => result.title === req.body.title),
    if (articleExists) {
        return res.send("Article already exists!")
    }
    const newArticle = new Article({
        title: req.body.title,
        content: req.body.content
      });
    newArticle.save(err => {
      if (err) {
        return res.send(err);
      } else {
        return res.send("Article saved successfuly")
      }
    });
});

edited Apr 23, 2020 at 18:30

answered Apr 23, 2020 at 17:37

catastrophic error

3901 gold badge5 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

catastrophic error Over a year ago

Just added an query value, which maybe be better to filter what you are querying instead of getting all registers with find()

Collectives™ on Stack Overflow

Why can't I set my javascript variable to false?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related