How to use a looping variable inside a callback in JavaScript/TypeScript?

Question

I've a method like this in my ts file

getInitialBatches() {
    var i = 0;
    for (var dto of this.transferDTO.stockMovesDTOs) {
        i++;

        this.queryResourceService
            .getBatchIdUsingGET(this.batchParams)
            .subscribe((data) => {
                this.allBatches[i] = data;
            });
    }
}

Since getBacthIdUsingGET is a callback, It is not functioning the way I want.loop control variable i gets increased by more than 1 by the time call back gets invoked so I'm not able to put values into every index of allBatches array, Value is getting placed into random indexes. how to solve this issue?

Does this answer your question? JavaScript closure inside loops – simple practical example — ASDFGerte
– ASDFGerte, Commented May 1, 2020 at 13:40

B45i · Accepted Answer · 2020-05-01 13:37:50Z

1

There are some issues with vars in loops, and it was specifically part of the let specification that lets this work properly. https://wesbos.com/for-of-es6

In general, it's best practice to avoid using vars due to their weirdness in certain instances and their scoping mechanisms.

getInitialBatches() {
    for (let i = 0; i < this.transferDTO.stockMovesDOTs.length; ++i) {
        this.queryResourceService
            .getBatchIdUsingGET(this.batchParams)
            .subscribe((data) => {
                this.allBatches[i] = data;
            });
    }
}

edited May 1, 2020 at 13:37

B45i

2,6673 gold badges28 silver badges38 bronze badges

answered May 1, 2020 at 13:33

Zachary Haber

11.1k1 gold badge22 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to use a looping variable inside a callback in JavaScript/TypeScript?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related