I want to make a program looping over array and then looping backwards. How can I make it better with less code in C? Array has 8 elements!
while (1) {
if (i == 0) {
direction = 0; // RIGHT DIRECTION
}
if (i == 7) {
direction = 1; // LEFT DIRECTION
}
PORTD = array[i]; // NEEDED ARRAY ELEMENT
if (direction == 0) {
i++;
} else {
i--;
}
}
You can simplify your code by making direction the increment for the next index, 1 or -1.
Here is a modified version:
int i = 0, direction = 1;
for (i = 0;; i += direction) {
if (i == 0) {
direction = 1; // RIGHT DIRECTION
} else
if (i == 7) {
direction = -1; // LEFT DIRECTION
}
PORTD = array[i]; // NEEDED ARRAY ELEMENT
}
if ( i == 0 || i == 7 ) { direction *= -1; } would be even less typing, as long as the initial sign of direction is correct.As others have noted, you need to reverse the sign of the increment variable, and you then need to use a proper condition to terminate the loop:
#include <stdio.h>
int main()
{
int i = 0, direction = 1;
int PORTD, array[8] = {10, 11, 12, 13, 14, 15, 16, 17};
for (i = 0 ; i >= 0 ; i += direction)
{
PORTD = array[i];
printf("i=%d array[%d]=%d\n", i, i, array[i]);
if(i == (sizeof(array)/sizeof(array[0]))-1 )
direction = -1;
}
}
1or-1. Then add it toi. But you need stop condition too.arrayis for thoughint array [] = {0b00000001,0b00000010,0b00000100,0b00001000,0b00010000,0b00100000,0b01000000,0b10000000};