PHP - Infinite while loop from class

Question

I'm trying to create a while loop from the returned execution of a PDO statement in a class call Posts, but it's creating an infinite while loop even though the number of rows returns correct. This seems simple...Am I writing this wrong?

public function getRecent()
{
    $sql = "SELECT * FROM posts ORDER BY createdate DESC LIMIT 5";
    $stmt = $this->db->prepare($sql);
    $stmt->execute();

    return $stmt;

}

$post = NEW Posts($db);

echo $post->getRecent()->rowCount(); //5 results(correct)

while ($row = $post->getRecent()->fetch())
{
    //Creates infinite loop
}

Nick · Accepted Answer · 2020-05-06 00:52:07Z

1

Your problem is that every time you call $post->getRecent() it executes your query again and so $post->getRecent()->fetch() then returns the first row of the result set over and over again. Just make one call to $post->getRecent() and use that value in place of the other calls:

$post = NEW Posts($db);
$result = $post->getRecent();
echo $result->rowCount();
while ($row = $result->fetch()) {
    // process rows
}

answered May 6, 2020 at 0:52

Nick

147k23 gold badges67 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nick Over a year ago

@prosportal we've all been there. Sometimes you just need that second pair of eyes to look at the code.

Collectives™ on Stack Overflow

PHP - Infinite while loop from class

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related