problem with continuous motion using pygame

Question

I'm trying to get my character to move as long as the key is pressed but so far it moves once per single press and the key needs to be released for him to move again.

I've tried using the pygame.key.get_pressed() as shown and I can't figure out what's wrong with it.

def keyPressed(input_key):
    keysPressed = pygame.key.get_pressed()
    if keysPressed[input_key]:
        return True
    else:
        return False
...

run = True
while run:

    for event in pygame.event.get():
        if keyPressed(pygame.K_LEFT) and x > vel:
            x -= vel
...

Rabbid76 · Accepted Answer · 2020-05-18 06:49:35Z

1

You have to call pygame.key.get_pressed() in the application loop rather than the main loop. The event loop is only executed when an event occurs (like pygame.KEYDOWN). But the application loop is executed in every frame.
The typical use for pygame.key.get_pressed() may look as follows:

while run:

    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            run = False

    #<---| Indentation

    keys = pygame.key.get_pressed()
    if keys[pygame.K_LEFT] and x > vel:
        x -= vel
    if keys[pygame.K_RIGHT] and x < width-vel:
        x += vel

    # [...]

edited May 18, 2020 at 6:49

answered May 17, 2020 at 7:26

Rabbid76

212k30 gold badges163 silver badges205 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Brandy Over a year ago

thank you for answering, I have tried doing it exactly as you've written down but it still doesn't work. maybe it's something to do with Pycharm or a version of pygame..? I'm at a loss.

Rabbid76 Over a year ago

@Brandy Then you've another bug elsewhere. Did you respect the Indentation?

Brandy Over a year ago

That was it! thank you! I thought I needed to put the keypress within the event.get() for some reason, that was dumb of me.

Collectives™ on Stack Overflow

problem with continuous motion using pygame

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related