how to append a data at a list and plot it with python plotly

Question

hi there i m still trying to get trade bot and try to plot them with their time and low price data. i wanna get buy signals that i ve specified at if condition (when macdh turns from negative to positive). then i want to plot them at a data. but can not add them at buy_signal=[] place.
my error is self.plotData(buy_signals = buy_signals) IndexError: list index out of range

import requests
import json
from stockstats import StockDataFrame as Sdf
import plotly.graph_objects as go
from plotly.offline import plot


class TradingModel:
    def __init__(self, symbol):
        self.symbol = symbol
        self.df = self.getData


    def getData(self):

        # define URL
        base = 'https://api.binance.com'
        endpoint = '/api/v3/klines'
        params = '?&symbol='+self.symbol+'&interval=4h'

        url = base + endpoint + params

        # download data
        data = requests.get(url)
        dictionary = data.json()

        # put in dataframe and clean-up
        df = pd.DataFrame.from_dict(dictionary)
        df = df.drop(range(6, 12), axis=1)


        # rename columns and stockstasts
        col_names = ['time', 'open', 'high', 'low', 'close', 'volume']
        df.columns = col_names
        stock = Sdf.retype(df)


        for col in col_names:
            df[col]=df[col].astype(float)
        #defined macdh
        df['macdh']=stock['macdh']


        return  (df)

    def strategy(self):
        df = self.df
        buy_signals=[]
        for i in range(1, len(df['close'])):
                if df['macdh'].iloc[-1]>0 and df['macdh'].iloc[-2]<0:
                    buy_signals.append([df['time'][i], df['low'][i]])

        self.plotData(buy_signals = buy_signals)





    def plotData(self,buy_signal=False):
        df=self.df
        candle=go.Candlestick(
            x=df['time'],
            open=df['open'],
            close=df['close'],
            high=df['high'],
            low=df['low'],
            name="Candlesticks"
        )
        macdh=go.Scatter(
            x=df['time'],
            y=df['macdh'],
            name="Macdh",
            line = dict(color=('rgba(102, 207, 255, 50)')))

        Data=[candle,macdh]

        if buy_signals:
            buys = go.Scatter(
                    x = [item[0] for item in buy_signals],
                    y = [item[1] for item in buy_signals],
                    name = "Buy Signals",
                    mode = "markers",
                )

            sells = go.Scatter(
                    x = [item[0] for item in buy_signals],
                    y = [item[1]*1.04 for item in buy_signals],
                    name = "Sell Signals",
                    mode = "markers",
                )

            data = [candle, macdh, buys, sells]


        # style and display
        layout = go.Layout(title = self.symbol)
        fig = go.Figure(data = data, layout = layout)

        plot(fig, filename=self.symbol)

def Main():
    symbol = "BTCUSDT"
    model = TradingModel(symbol)
    model.strategy()

if __name__ == '__main__':
    Main() ```

it would be helpful if you could make it more readable by only posting the relevant parts of your code? — Emma H
– Emma H, Commented May 18, 2020 at 21:18
Why are you cross-posting this in r? Any r relevant question you have? — Shan R
– Shan R, Commented May 18, 2020 at 21:19
I cannot actually find self.plotData(buy_signals[i]) in your code, only self.plotData(buy_signals = buy_signals) — Emma H
– Emma H, Commented May 18, 2020 at 21:25

Dr. Paprika · Accepted Answer · 2020-05-18 21:35:12Z

1

You need to replace :

self.plotData(buy_signals[i]) by self.plotData(buy_signals)

def plotData(self,buy_signal=False): by def plotData(self,buy_signals=None):

And it should be good to go !

answered May 18, 2020 at 21:35

Dr. Paprika

1641 gold badge3 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Alper Aşan Over a year ago

it works but i got another problem. if buy_signals==True: NameError: name 'buy_signals' is not defined

Alper Aşan Over a year ago

when i type this mate buysignals list is empty

Dr. Paprika Over a year ago

I can't see any if buy_signals==True: in your code

Alper Aşan Over a year ago

when i add [print(buy_signals)] under if condition i got a empty list

Alper Aşan Over a year ago

if df['macdh'].iloc[-1]>0 and df['macdh'].iloc[-2]<0: buy_signals.append([df['time'][i], df['low'][i]]) print(buy_signals) this list is empty

|

Collectives™ on Stack Overflow

how to append a data at a list and plot it with python plotly

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related