Loop to find max value

Question

Hi I'm having a problem to write a loop which finds the largest value.

A list of integers and an integer variable are declared like this: List list; int max;

Assuming that some values (including negatives!) have been added to the list. i need to find the largest value in list and stores it in max.

//  start of test code 
import java.util.*; 
public class ListTest 
{ 
private List<Integer> list; 
private int max;
public void findMaxInListTest()         { 
list = new ArrayList<Integer>(); // could be a Linked list 
list.add(0);
list.add(-99); 
list.add(99);
list.add(1320); 
list.add(470000); 
list.add(12);
list.add(-5000);
list.add(300);
/*#     max = starting value 
iterate through list to set max = max value in list 
in this case 470000     */ 
} 
}

I tried using this loop but then encounter an error:

int max = list[0];
  for(int i=470000;i < list.length;i++){
    if(list[i] > max){
      max = list[i];
    }
  }
return max;

do you know which kind of loop that appropriate for this? Thanks

Hi Please see the answer here stackoverflow.com/questions/1484347/… — r0ast3d
– r0ast3d, Commented May 31, 2011 at 23:18
Welcome to Stack overflow, and check the syntax formatting possibilities. — Ondra Žižka
– Ondra Žižka, Commented May 31, 2011 at 23:20

Adam Dymitruk · Accepted Answer · 2011-05-31 23:14:29Z

3

You need to iterate over the list. Start with i=0 - not 47000.

Hope this helps.

answered May 31, 2011 at 23:14

Adam Dymitruk

131k28 gold badges149 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dariusz Jędrzejczyk · Accepted Answer · 2011-05-31 23:16:23Z

2

for(int i=470000;i < list.length;i++){

i is the index. put i=0. getting list element for index 470000 throws the exception.

also, list[i] doesn't work in java. use list.get(i). also, list.length doesn't work on lists. use list.size().

You're misinterpreting java List - it's not an array.

answered May 31, 2011 at 23:16

Dariusz Jędrzejczyk

9111 gold badge8 silver badges12 bronze badges

1 Comment

Balazs Gunics Over a year ago

also make max = list.get(0); so you initialize your max, if a number in the list is bigger than the first item,then you replace max with that.

Eder · Accepted Answer · 2011-05-31 23:59:34Z

2

import java.util.Collections;

Collections.sort(list);
System.out.println(list.get(list.size() - 1));

answered May 31, 2011 at 23:59

Eder

1,88418 silver badges35 bronze badges

Comments

DarthJDG · Accepted Answer · 2011-06-01 12:41:55Z

1

for(int i=470000;i < list.length;i++){

should be

for(int i=0;i < list.length;i++){

edited Jun 1, 2011 at 12:41

DarthJDG

16.6k11 gold badges52 silver badges56 bronze badges

answered May 31, 2011 at 23:15

Brad Johnson

1211 silver badge3 bronze badges

Comments

moeTi · Accepted Answer · 2013-06-27 09:56:54Z

1

No loop required, use max method from java.utils.Collections (Documentation)

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

public class Test {

    public static void main(String[] args) {

        List<Integer> list = new ArrayList<Integer>();
        list.add(0);
        list.add(-99);
        list.add(99);
        list.add(1320);
        list.add(470000);
        list.add(12);
        list.add(-5000);
        list.add(300);

        System.out.println(Collections.max(list));
    }
}

edited Jun 27, 2013 at 9:56

answered Jun 27, 2013 at 9:50

moeTi

3,92427 silver badges37 bronze badges

Collectives™ on Stack Overflow

Loop to find max value

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related