Not able to assign data value returned from api to class variable in Angular 8

Question

I am calling api to get data on ngOnInit. However I am not able to assign the data class variable. Below is the related code

  tasks: Task[];

  ngOnInit() {

    this.apiService.getTasks()
      .subscribe( data => {
        Object.keys(data).map((index) => {
          this.tasks.push(data[index]);
       });
      });

  }

I get error saying 'TypeError: Cannot read property 'push' of undefined' for statement

this.tasks.push(data[index]);

But the tasks is already defined as array.

Can anyone help me here, the scope really confuses me

Thank you @SameerKhan, How could I not see that, Thanks for pointing out — Chetan
– Chetan, Commented May 29, 2020 at 9:42

Barremian · Accepted Answer · 2020-05-29 09:49:53Z

1

If all you do in the map is to return the value of the property, you could use Object.values().

this.apiService.getTasks().subscribe(data => {
  this.tasks = Object.values(data);
});

answered May 29, 2020 at 9:49

Barremian

31.2k4 gold badges37 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aakash Garg · Accepted Answer · 2020-05-29 09:39:13Z

0

Map will return a new array so no need of pushing inside map. Hence Your code should be

this.apiService.getTasks()
      .subscribe( data => {
        this.tasks = Object.keys(data).map((index) => {
         return data[index];
         });
      });

answered May 29, 2020 at 9:39

Aakash Garg

11k2 gold badges11 silver badges29 bronze badges

Collectives™ on Stack Overflow

Not able to assign data value returned from api to class variable in Angular 8

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related