Creating a loop for an else statement inside a function

Question

I am trying to create a loop to include an else statement. It works perfectly with the if statement as below but when trying to put in the else statment it either shows nothing or creates 6 loops. Im assuming I am putting the else statement in the wrong place. Can someone please explain to me a) where to put the else statement and b) the nesting criteria of the ending curly braces inside a function Heres what ive got and it works perfectly until i place the else statement in. thanks

var sports = ["golf", "cricket", "tennis", "badminton", "squash"];

function checkSport(sportToCheck) {
    for (var i = 0; i <= sports.length; i++) {
        if (sportToCheck == sports[i]) {
            alert("yes we offer that sport");
        }
    }
}

checkSport("tennis")

What exactly are you trying to do? The code above works perfectly, assuming you want to check if the string parameter (in checkSport()) exists inside the sports array. — Nanoo
– Nanoo, Commented Jun 20, 2020 at 0:42
you could refactor this code into alert(sports.includes("tennis") ? 'yes ...' : 'no ...') sorry — Lawrence Cherone
– Lawrence Cherone, Commented Jun 20, 2020 at 0:48
you can probably tell im fairly new in my learning. I want an else statment that reads " no we dont offer that sport" If i put it in by individually checking the nodes and attaching it to the end of the last else if including all 5 nodes, it works but doesnt work in the loop, thanks for reply — user13752749
– user13752749, Commented Jun 20, 2020 at 1:18
if i change the sport to football i want an else statement to appear saying " sorry we dont do that sport. Its just when i put the Else statment in , it doesn't work, i have tried nesting it everywhere but where to put it and the hierachy nesting of the curly braces is my problem i think — user13752749
– user13752749, Commented Jun 20, 2020 at 1:30

hangindev.com · Accepted Answer · 2020-06-20 01:01:19Z

3

Based on your variable names, I guess you don't have to use else in this context but you would like to end the loop/function as soon as the sport is found:

function checkSport(sportToCheck) {
  for (var i = 0; i <= sports.length; i++) {
    if (sportToCheck == sports[i]) {
      alert("yes we offer that sport");
      return; // stop the execution of the function
    } else {
      console.log("Do nothing so you don't need this else statement.");
    }
  }
  alert("No we don't offer that sport"); //  If the loop ends and cannot find any match
}

edited Jun 20, 2020 at 1:01

answered Jun 20, 2020 at 0:42

hangindev.com

4,89214 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ala Eddine Menai Over a year ago

You started your index with 0 and you make it equal to length.

Ala Eddine Menai · Accepted Answer · 2020-06-20 02:12:36Z

1

Because your function is check() and to respect Do One Thing rule, it's better to return true or false.

There are many ways to solve your issue but I prefer find().

var sports = ["golf", "cricket", "tennis", "badminton", "squash"];

function checkSport(sportToCheck) {
  return sportToCheck === sports.find((sport) => sport === sportToCheck);
}
   
console.log(checkSport("football")); // Expect : false
console.log(checkSport("tennis"));   // Expect : true

If you want to improve @Hangindev answer you can do this:

   for (sport of sports) {
     true === (sportToCheck === sport) && alert("yes we offer that sport");
   }

edited Jun 20, 2020 at 2:12

answered Jun 20, 2020 at 1:16

Ala Eddine Menai

2,9047 gold badges32 silver badges61 bronze badges

Comments

Nanoo · Accepted Answer · 2020-06-20 01:05:04Z

-1

No need for else statements. Simply run through each possible value in the sports array, and use the return statement to pause further script execution within that function.

The function returns either true or false depending on whether the string is inside the sports array.

var sports = ["golf", "cricket", "tennis", "badminton", "squash"];

function checkSport(sportToCheck) {
    for (var i = 0; i <= sports.length; i++) {
        if (sportToCheck == sports[i]) {
            alert("yes we offer that sport");
            return true;
        }
        if (i == sports.length) {
            alert("sorry we do not offer this sport");
            return false;
        }
    }
}

checkSport("tennis")

You could use this for something like:

if (checkSport("tennis")) {
    // sport exists
} else {
    // sport does not exist
}

answered Jun 20, 2020 at 1:05

Nanoo

9019 silver badges19 bronze badges

2 Comments

Pointy Over a year ago

There's no reason for the second if statement, and the loop condition should be < not <=. All that's necessary is that second alert() and return false; after the loop but inside the function.

user13752749 Over a year ago

thanks , im in the early learning of javascript, im sure there is a far better way of doing what i am trying to do , i jut want to know how i could do it the way i wanted above, mainly to aid my understanding of it , thanks

Collectives™ on Stack Overflow

Creating a loop for an else statement inside a function

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related