Javascript error - unexpected identifier

Question

I have PHP code that tries to output JavaScript and I do something like this:

trailhead_name = <?php echo $objkey->trailhead_name ?> + "";

And I get the unexpected identifier error in my JS.

Try running your js through jslint.com, it will often give a more specific error. — Evgeny Shadchnev
– Evgeny Shadchnev, Commented Jun 6, 2011 at 16:43
Don't show us what you do "something like", show us what you do. — Quentin
– Quentin, Commented Jun 6, 2011 at 16:44
Don't show us some PHP that generates some JavaScript which throws an error, show us the JavaScript. — Quentin
– Quentin, Commented Jun 6, 2011 at 16:44

T.J. Crowder · Accepted Answer · 2011-06-06 16:44:08Z

3

If trailhead_name is a string, you need to put quotes around it (and properly escape anything within it that may not be a valid JavaScript string — like a quote!).

PHP's built-in JSON encoder can do that for you:

trailhead_name = <?php echo json_encode($objkey->trailhead_name) ?>;

Again, that assumes that trailhead_name is a string.

answered Jun 6, 2011 at 16:44

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ionuț G. Stan · Accepted Answer · 2011-06-06 16:44:34Z

1

Use json_encode:

var trailhead_name = <?php echo json_encode($objkey->trailhead_name); ?>;

answered Jun 6, 2011 at 16:44

Ionuț G. Stan

180k19 gold badges196 silver badges206 bronze badges

Collectives™ on Stack Overflow

Javascript error - unexpected identifier

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related