javascript append from foreach loop not working

Question

I am writing simple changelog for my website that uses github api and appends tag but it doesnt work.

this is my code:


<p id="testing"></p>

<script>
var c = document.getElementById("testing");
$.getJSON("https://api.github.com/repos/test234/test/releases").done(function (json) {
for each (release in json) {
c.appendChild(document.createTextNode(release.tag_name));
}
});
</script>

I think something is wrong with my foreach loop.

Any help is welcome I am stuck here for a long time

for each looks like a syntax error. Perhaps this is just a typo? Check your browser console for errors. — David
– David, Commented Jun 30, 2020 at 17:45
Hello thank you for your answer but my problem is: Uncaught SyntaxError: Unexpected identifier — Margarita Weiß
– Margarita Weiß, Commented Jun 30, 2020 at 17:47

Majed Badawi · Accepted Answer · 2020-06-30 17:50:11Z

3

This is the right way to use forEach:

var c = document.getElementById("testing");
$.getJSON("https://api.github.com/repos/4u7157/DOWNLOADS/releases").done(function (json) {
     json.forEach((e) => {
          console.log(e);
          c.appendChild(document.createTextNode(e.tag_name));
     });
});

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<p id="testing"></p>

You can also use JQuery as follows:

var c = document.getElementById("testing");
$.getJSON("https://api.github.com/repos/4u7157/DOWNLOADS/releases").done(function (json) {
     $.each(json, function( index, e ){
          console.log(e);
          c.appendChild(document.createTextNode(e.tag_name));
     });
});

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<p id="testing"></p>

edited Jun 30, 2020 at 17:50

answered Jun 30, 2020 at 17:47

Majed Badawi

28.5k4 gold badges30 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

VR7 · Accepted Answer · 2020-06-30 18:28:03Z

0

well, the reason is that your syntax is appropriate for arrays but here json is object so this syntax will not work unless you use Object.Entries

const entries = Object.entries(json)
  for(const [index,obj] of entries){
    c.appendChild(document.createTextNode(obj.tag_name))
  }

or you can use for each method provided for objects like this :

json.forEach(function(value,key,obj){
    c.appendChild(document.createTextNode(value.tag_name))
});

Rest is all good , you just need to look for these changes.

answered Jun 30, 2020 at 18:28

VR7

1123 silver badges16 bronze badges

Collectives™ on Stack Overflow

javascript append from foreach loop not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related