setting XML file variables to in-code variables is not working

Question

I am absolutely baffled as to why this won't work. My code will write values directly to the XML file however for some odd reason I can't seem to take the values from said file and "import" them into there individual respective variables. Consider the following:

public class SaveLoadConfiguration
        {
         
            public int height { get; set; }
         
            public int width { get; set; }
           
            public int frameratecap { get; set; }
           
            public bool cap { get; set; }

public SaveLoadConfiguration LoadGameData(string fileName) // SavedGameData.xml
            {
                XmlSerializer serializer = new XmlSerializer(typeof(SaveLoadConfiguration));
                StreamReader LoadGameData = new StreamReader(fileName);
                return (SaveLoadConfiguration)serializer.Deserialize(LoadGameData);              
            }
}

What should happen here is when I call the LoadGameData method as a property from SaveLoadConfiguration class it should simply take the XML file contents ( height, width, frameratecap , and cap variables are all written to the XML file in there respective orders ) and send them to there respective variables. However, this is simply not working. When the code compiles, regardless of what these variables in the XML file are, or what has been listed on those files on a previous state, or anything really, it prints 0 to the screen if I print anyone of those variables ( after loading them using the LoadGameData method which also should set the XML file contents to their individual respective variable correlation such as height, width, frameratecap and cap etc... ). I checked the entirety of the XML documentation, I just simply cannot fathom why it is doing it. I have suspicion that perhaps one of said XML file variables are not being setted to their respective variables within the code and thus printing it no matter the result is 0. I don't really know. If anyone can help it would be appreciated.

XML file: ( contents within it notably the height variable has already been set using a write method that writes directly to the XML file as intended )

<SaveLoadConfiguration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <height>1080</height>
  <width>0</width>
  <frameratecap>0</frameratecap>
  <cap>false</cap>
</SaveLoadConfiguration>

Open xml file with notepad and see if it looks correct. Usually issue is with namespaces so you may of generated a file with namespaces and since there are no namesapces in the classes you will not get any data. — jdweng
– jdweng, Commented Jul 22, 2020 at 12:58
you call the LoadGameData from an existing instance? your method returns a new instance wich goes to nowhere, instead of setting the props on himself — dba
– dba, Commented Jul 22, 2020 at 13:14

dba · Accepted Answer · 2020-07-22 14:28:34Z

1

for XML-serialization you need a few more attributes:

[System.Serializable()]
[System.ComponentModel.DesignerCategory("code")]
[System.Xml.Serialization.XmlType(AnonymousType = true)]
[System.Xml.Serialization.XmlRoot(Namespace = "", IsNullable = false)]
public partial class SaveLoadConfiguration
{
  public int height { get; set; }
  public int width { get; set; }
  public int frameratecap { get; set; }
  public bool cap { get; set; }  

 public static  SaveLoadConfiguration LoadGameData(string fileName) // SavedGameData.xml
  XmlSerializer serializer = new XmlSerializer(typeof(SaveLoadConfiguration));
  using (StreamReader LoadGameData = new StreamReader(fileName))
  {
    return (SaveLoadConfiguration)serializer.Deserialize(LoadGameData);
  }
}

usage

var data = SaveLoadConfiguration.LoadGameData ("myPath");

you will be able to deserialize:

<SaveLoadConfiguration>
  <height>10</height>
  <width>10</width>
  <frameratecap>10</frameratecap>
  <cap>true</cap>
</SaveLoadConfiguration>

edited Jul 22, 2020 at 14:28

answered Jul 22, 2020 at 13:08

dba

1,2151 gold badge15 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Mike Fernandez Over a year ago

so var data will contain the XML file variables ( height,` width` etc... ) because I just want the XML file variables to be correspondent to their respective counterparts within my cs file so I can access them directly.

dba Over a year ago

the data holds an instance of your class with the information in the XML. You can use the instance to access the values. If you don't want a class instance, just read-write single values, then you will need a different approach: learn.microsoft.com/en-us/dotnet/csharp/programming-guide/…

Mike Fernandez Over a year ago

How would I access the individual values within data ? Or any values for that matter?

dba Over a year ago

since data is of Type SaveLoadConfiguration, you can access its properties like data.height, data.width, etc.

Mike Fernandez Over a year ago

oh ok I see I'm going to try that! edit: Thanks, that did it!

|

jpablo27 · Accepted Answer · 2020-07-22 12:39:47Z

0

I think you are missing

[Serializable]
public class SaveLoadConfiguration
        {

try that out

answered Jul 22, 2020 at 12:39

jpablo27

1117 bronze badges

3 Comments

Mike Fernandez Over a year ago

Unfortunately, it still prints 0 to the screen.

jpablo27 Over a year ago

Could you post the xml file ?

Mike Fernandez Over a year ago

I posted the XML file

Collectives™ on Stack Overflow

setting XML file variables to in-code variables is not working

2 Answers 2

6 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related