jQuery: Run custom function 'if' if statement is false

Question

The custom function formdvalidate should run after else but it doesn't. How can I trigger it to run? What I like to accomplish here is to check the text-fields of a form. If there are less then 3 characters its show the user some text. If the input is more then 3 it submits the form.

--I was thinking to wrong way, this works better.

$('#submit').click(formdvalidate);

The function

function formdvalidate(){
    $(".form-sel").each(function(){
        var n = $(this).closest('.contain-form').find('.custom:first').val().length;
        if ($('option:selected', this).val() === 'custom' && n < 3) {
            $(this).closest('.contain-form').find('.alert-short:first').show();
        }else{                          
            $('#poll').submit();
        }
    });                 
}

I see. Didn't know that. Its seem like I have to change a lot more to make this code work. — Rob
– Rob, Commented Jun 14, 2011 at 14:25

JAAulde · Accepted Answer · 2011-06-14 14:51:34Z

A function assigned as a click handler via .click() takes a jQuery event object as its first param--you named that param the same as your function
formdvalidate === true will never evaluate to true as formdvalidate is a function in the global scope, and a jQuery event object in the click() scope as per item 1
In your formdvalidate function, your return is inside of the .each() function, so formdvalidate never actually returns anything.

I'm not sure what you're really after or what your page looks like, but based on your comment to Slava Yanson, my best guess for you is below (although there are still things I am unsure of...)

$( '#submit' ).click( function( e )
{
  if( formdvalidate() === true) 
  {
    $( '#poll' ).submit();
  }

  e.preventDefault();
} );

function formdvalidate()
{
  var returnValue;

  $( '.form-sel' ).each( function()
  {
    var $containForm = $( this ).closest( '.contain-form' ),
        $alertShortFirst = $containForm.find( '.alert-short:first' ),
        n = $containForm.find( '.custom:first' ).val().length;
    if( $( 'option:selected', this ).val() === 'custom' && n < 3 )
    {
      $alertShortFirst.show();
      returnValue = false;
    }
    else
    {
      $alertShortFirst.hide();
      returnValue = true;
    }
  } );

  return returnValue;
}

SLaks · Accepted Answer · 2011-06-14 14:15:19Z

1

The formdvalidate parameter is hiding the formdvalidate function.

Use better names.

answered Jun 14, 2011 at 14:15

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Comments

sjobe · Accepted Answer · 2011-06-14 14:16:24Z

1

Try

$('#submit').click(function() {
 if (formdvalidate() === true)  {
     $('#poll').submit();
        } else {        
             formdvalidate();
        }

});

I don't know if your logic will accomplish what you're trying to though.

answered Jun 14, 2011 at 14:16

sjobe

2,8373 gold badges24 silver badges33 bronze badges

2 Comments

JAAulde Over a year ago

Agreed--that would seem the most obvious edit, and yet we have no way of knowing if it is desired. Especially since it doesn't seem to make sense to run formdvalidate again after it failed.

sjobe Over a year ago

@JAAulde "Especially since it doesn't seem to make sense to run formdvalidate again after it failed." exactly what I was thinking

Slava Yanson · Accepted Answer · 2011-06-14 14:14:18Z

0

On line 2 of your code you are comparing an instance of your function to boolean. That won't validate. Can you provide more information on what you are trying to accomplish?

answered Jun 14, 2011 at 14:14

Slava Yanson

714 bronze badges

1 Comment

Rob Over a year ago

In essence the functions should show a text when the input is less then 3 characters.

Matt MacLean · Accepted Answer · 2011-06-14 14:15:08Z

0

Your argument "formvalidate" is shadowing your "formvalidate" function. Just rename your argument to something like this:

$('#submit').click(function(do_validate) {
 if (do_validate === true)  {
     $('#poll').submit();
        } else {        
             formdvalidate();
        }
});

answered Jun 14, 2011 at 14:15

Matt MacLean

19.7k7 gold badges52 silver badges54 bronze badges

1 Comment

JAAulde Over a year ago

do_validate will never be === true as it is a jQuery event object (first param to a click handling function which was assigned via .click()

Collectives™ on Stack Overflow

jQuery: Run custom function 'if' if statement is false

5 Answers 5

Comments

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related