Promise inside the if() function returns undefined in Javascript

Question

// Password match var
var checkPassword = null;

// Find user by email
const auth = await Auth.findOne({ userEmail }, { userLoginInfo: 0 });

// If user does not exist
if (auth === null) {
  return res
    .status(400)
    .json({ authFailedMessage: 'Email or password is incorrect' });
} else if (auth !== null) {
  // Check password when user exists
  const returnVal = await checkPasswordService.matchPassword(
    password,
    auth.password 
  ).then((returnVal) => {
    console.log(returnVal) ----> undefined
    returnVal = checkPassword
  }
  )
}

This is my main function. I want to set 'checkPassword' to the return value from 'checkPasswordService'. And, this is my 'checkPassowrdService'.

class checkPasswordService { 
    static async matchPassword(passwordInput, passwordDB) {
        console.log('passint', passwordInput)
        console.log('passDB', passwordDB)
       await bcrypt.compare(passwordInput, passwordDB).then((isMatch) => {
           if(isMatch) {
               console.log('matttched!') -------->returning 'mattched!'
               return true
           } else {
               return false
           }
       })
    }
}

I see the console.log of 'matttched1'. However, in the main function, console.log(returnVal) is 'undefined'. How can I get the value of 'true' or 'false' from checkPasswordService?

You are mixing the async/await with callbacks, you should use only one of them. — Tamas Szoke
– Tamas Szoke, Commented Aug 22, 2020 at 19:51

charlietfl · Accepted Answer · 2020-08-22 19:51:59Z

4

You have no return in matchPassword()

Return the bycrypt promise

return bcrypt.compare(passwordInput, passwordDB).then((isMatch) => {..

answered Aug 22, 2020 at 19:51

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Spack Jarrow · Accepted Answer · 2020-08-22 19:56:47Z

1

There's a problem with your code. You are both 'awaiting' for the promise checkPassowrdService as well as using a .then() at the end. Both serve the same purpose.

I suggest you remove the .then() at the end and use the following piece of code instead:

const returnVal = await checkPasswordService.matchPassword(password, auth.password)
    returnVal = checkPassword

answered Aug 22, 2020 at 19:56

Spack Jarrow

3602 silver badges9 bronze badges

Collectives™ on Stack Overflow

Promise inside the if() function returns undefined in Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related