How to validate @PathVariable is set?

Question

Here is my Get request:

@GetMapping("/stats/{fromDate}/{toDate}")
public StatsSummary getStatsSummary(@PathVariable String fromDate, @PathVariable String toDate) {

    logger.info("Calculating statistics between" + fromDate + ",to" + toDate);

    return statsService.getStatsSummary(fromDate, toDate);

}

I've tried adding the annotation @NotBlank as:

public StatsSummary getStatsSummary(@PathVariable String fromDate, @PathVariable @NotBlank String toDate) {

but when I invoke /stats/2020-05-30/ which does not include toDate I receive the response:

{
    "timestamp": "2020-09-04T06:02:46.567+00:00",
    "status": 404,
    "error": "Not Found",
    "message": "No message available",
    "path": "/stats/2020-05-30/"
}

So the annotation is not being registered correctly?

Update:

It seems PathVariable is not meant to be validated:

The validators (@Validated @Valid) do not work with Spring and TomEE

I too faced same issue I have added answer below, please accept if this solves your problem. — Sandeep Pandey
– Sandeep Pandey, Commented Sep 4, 2020 at 6:41

Rafa C. · Accepted Answer · 2020-09-04 07:10:37Z

2

In REST, path variables are part of the resource URL. Therefore, if a part of the path/URL is missing, the resource is different.

That is why a 404 is the correct response code.

If those two variables can be empty, they should be @RequestParam.

answered Sep 4, 2020 at 7:10

Rafa C.

637 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dejan · Accepted Answer · 2020-09-04 06:40:31Z

1

Actually Spring by sending 404 returns correct answer to a client. When someone doesn't provide full URL, the 404 is the status to respond.

The proper way to validate that is to use some date class like Date or LocalDate or similar instead of String. Probably you'll need to define proper formatting of date so take a look at the following link for details. https://www.baeldung.com/spring-date-parameters

answered Sep 4, 2020 at 6:40

Dejan

3532 silver badges12 bronze badges

Collectives™ on Stack Overflow

How to validate @PathVariable is set?

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related