Javascript: converting string to an array

Question

This is one of my function for a calculator project. First I needed to convert the input string into an array, and do the operation later. (assuming that input has only numbers and '+' sign for now.

My question here is, how do I improve this code? What are the other ways to deal with this problem? (Time complexity, cleanness, shorter code.......whatever)

function convertArray(input) {
  let array = [];
  let num = "";
  for (let i = 0; i < input.length; i++) {
    if (input.charAt(i) == '+') {
      array.push(input.charAt(i));
    } else {
      do {
        num += input.charAt(i);
        i++;
      } while (i < input.length && input.charAt(i) !== '+');
      array.push(num);
      num = "";
      i--;
    }
  }
  return array;
}

console.log(convertArray("10+2+3000+70+1"));

Not about making sense, more about being on topic. Please visit the help center, take the tour to see what and How to Ask. Do some research, search for related topics on SO; if you get stuck, post a minimal reproducible example of your attempt, noting input and expected output using the [<>] snippet editor. — mplungjan
– mplungjan, Commented Sep 4, 2020 at 10:40

Nina Scholz · Accepted Answer · 2020-09-04 11:27:07Z

2

You could split with a group. this add the group as well to the array.

For other calculation signs, you could add them to the brackets.

const convertArray = string => string.split(/([+])/);

console.log(convertArray("10+2+3000+70+1"));

edited Sep 4, 2020 at 11:27

answered Sep 4, 2020 at 10:54

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

mplungjan Over a year ago

Arrgh. Took me several minutes playing with exec to do this!

mplungjan Over a year ago

At least mine can see if it is an operator or not

mplungjan · Accepted Answer · 2020-09-04 10:55:47Z

0

It seems the complexity must have something to do with your wish to determing operators. In your code you just push them all into the array. To do that is like

const re = /((\d+)|([^\d]+))/g
const convertArray = str => {
  let match, arr=[];
  while (match = re.exec(str)) {
    arr.push(match[1]) // here you can determine if you have an operator
    console.log(match[1],"Operator?",!/^\d+$/.test(match[1]))
  }
  return arr
}
const str = "10+2+3000+70+1";

console.log(convertArray(str));

answered Sep 4, 2020 at 10:55

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Collectives™ on Stack Overflow

Javascript: converting string to an array

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related