Javascript array problem

Question

I have an array that i wish to looking into and only print something out when the array== another variable, however it seems to print out the statement whatever, am I missing something stupid?

var candArray = 
['Green...', 'Brown...', 'Black...', 'White...', 'Grey....','Blue....', 'Pink....'];

var votesArray= [33,51,43,22,61,51,47];
var maximumVote = 61;

for(i=0; i<candArray .length; i++){
if(votesArray[i] == maximumVote);{
 document.write(candArray [i] + ' is hearby declared elected');}
}

All help appreciated. Thanks

EDIT: OMG i knew it was something simple, but ive been doing it so like 2 hours and just got into that phase where you dont check the simple things because you're too wound up. many thanks all

Is there also a space between candArray and .length in your actual code, or is that only from what you posted here? — kinakuta
– kinakuta, Commented Jun 16, 2011 at 16:59
You should really use var i so your loop variable doesn't become global. — ThiefMaster
– ThiefMaster, Commented Jun 16, 2011 at 17:00

SLaks · Accepted Answer · 2011-06-16 16:59:26Z

5

Remove the ; after the if.

An if statement affects the statement or block immediately after it.

You have an empty statement (;) after your if, so the subsequent block is not affected by the if.

answered Jun 16, 2011 at 16:59

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fosco · Accepted Answer · 2011-06-16 16:59:37Z

2

You had a semi-colon after your if condition... It nullified your conditional, and then the code block that followed ran every time.

for(i=0; i < candArray.length; i++){
 if(votesArray[i] == maximumVote) {
   document.write(candArray [i] + ' is hearby declared elected');
 }
}

answered Jun 16, 2011 at 16:59

Fosco

38.6k7 gold badges90 silver badges101 bronze badges

Comments

Naftali · Accepted Answer · 2011-06-16 17:00:08Z

2

Remove the ; after the if statement:

var candArray = 
['Green...', 'Brown...', 'Black...', 'White...', 'Grey....','Blue....', 'Pink....'];

var votesArray= [33,51,43,22,61,51,47];
var maximumVote = 61;

for(i=0; i<candArray .length; i++){
if(votesArray[i] == maximumVote){ //<--remove the ;
 document.write(candArray [i] + ' is hearby declared elected');}
}

answered Jun 16, 2011 at 17:00

Naftali

147k41 gold badges247 silver badges304 bronze badges

Comments

david · Accepted Answer · 2011-06-16 17:00:59Z

2

You have a semicolon after your 'if' statement that's messing it up.

Fixed:

var candArray = 
['Green...', 'Brown...', 'Black...', 'White...', 'Grey....','Blue....', 'Pink....'];

var votesArray= [33,51,43,22,61,51,47];
var maximumVote = 61;

for(i=0; i<candArray .length; i++){
if(votesArray[i] == maximumVote){
 document.write(candArray [i] + ' is hearby declared elected');}
}

answered Jun 16, 2011 at 17:00

david

18.3k4 gold badges45 silver badges60 bronze badges

Comments

Daniel Cassidy · Accepted Answer · 2011-06-16 17:02:05Z

1

The problem is a misplaced semicolon.

if(votesArray[i] == maximumVote);{
  document.write(candArray [i] + ' is hearby declared elected');}
}

should be:

if(votesArray[i] == maximumVote) {
  document.write(candArray [i] + ' is hearby declared elected');}
}

answered Jun 16, 2011 at 17:02

Daniel Cassidy

25.8k6 gold badges44 silver badges54 bronze badges

Collectives™ on Stack Overflow

Javascript array problem

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related