Delete Requests not persisting in node js

Question

Anytime I make a delete request to my node js server, it can only delete one item from my json file between server starts. If I try to make a second delete request, it works, but it also rewrites back the last item I deleted.

Here is the node js delete implementation using express:

const todos = require("./todos.json"); //Load the node js File
const fs = require("fs");

app.delete("/api/:id", (req, res) => {
  const id = req.params.id;
  let newTodos = todos.filter((todo) => {
    return todo.id !== id;
  });
  fs.writeFileSync(__dirname + "/todos.json", JSON.stringify(newTodos));
  todos = newTodos;
  res.send("Todo deleted");
});

This is how the items in the json file look they are contained in a regualar array:

  {
    "id": "bd58d991-bdda-4d8d-aca3-ae7ee01e1296",
    "activity": "Buy Groceries",
    "completed": false
  }

because you never update todos with the new content. it's always starting with the original file contents when you call .delete. — Joe
– Joe, Commented Sep 25, 2020 at 14:12

Anatoly · Accepted Answer · 2020-09-25 14:34:11Z

3

You should read todos.json at the beginning of delete handler.

app.delete("/api/:id", (req, res) => {
  const todos = fs.readFileSync("./todos.json", { encoding: 'utf-8' })
  ...

answered Sep 25, 2020 at 14:34

Anatoly

23.2k3 gold badges33 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Delete Requests not persisting in node js

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related