Node JS read in buffered data

Question

For some reason when I send a message to the port and attempt to read it in via a buffer, it always hangs as socket.on('end') never seems to be reached. Any ideas?

var net = require('net');
var buffer = [];

var server = net.createServer(function(socket) {

    socket.on('data', function(data) {
        buffer.push(data);
    });

    socket.on('end', function() {
        try {
            var data = buffer.join("");
            console.log(data);
            socket.end('ok');

        } catch (e) {
            console.log('Error: ' + e.message);
            return;
        }
    });
});

server.listen(3000, '127.0.0.1');

*Edit: here is the PHP that sends the command...

public function sendDaemonCommand($address, $template_id, $params = array()) {

    $port = 3000;
    $command = array('template_id' => $template_id, 'params' => $params);
    $command = json_encode($command);

    // Create a TCP Stream socket
    if (($sock = socket_create(AF_INET, SOCK_STREAM, SOL_TCP)) === false) {
        $this->logError("Failed to create socket on " . $address . "\n\n" . socket_strerror(socket_last_error()) . "\n\nCommand:\n\n" . $command . "\n" . $this->functionTraceback());
        return false;
    }

    // Connect to socket
    if (socket_connect($sock, $address, $port) === false) {
        $this->logError("Failed to connect to socket on " . $address . "\n\n" . socket_strerror(socket_last_error($sock)) . "\n\nCommand:\n\n" . $command. "\n" . $this->functionTraceback());
        socket_close($sock);
        return false;
    }

    // Write command to socket
    if (socket_write($sock, $command) === false) {
        $this->logError("Failed to write command to socket on " . $address . "\n\n" . socket_strerror(socket_last_error($sock)) . "\n\nCommand:\n\n" . $command. "\n" . $this->functionTraceback());
        socket_close($sock);
        return false;
    }

    // Read back from socket
    if (($out = socket_read($sock, 1024)) !== false) {
        $out = trim($out);
        if ($out == "") {
            $this->logError("No message received back from socket on " . $address . "\n\n" . socket_strerror(socket_last_error($sock)) . "\n\nCommand:\n\n" . $command. "\n" . $this->functionTraceback());
            socket_close($sock);
            return false;
        }
    }
    else {
        $this->logError("Failed to read from socket on " . $address . "\n\n" . socket_strerror(socket_last_error($sock)) . "\n\nCommand:\n\n" . $command. "\n" . $this->functionTraceback());
        socket_close($sock);
        return false;
    }

    socket_close($sock);
    return $out;
}

We need to see the client that connects. It's the client who's not ending the connection. — Raynos
– Raynos, Commented Jun 20, 2011 at 14:58
@fire maybe PHP is waiting for data back before it closes whilst node.js is waiting for the socket to close before it sends data back (.end("ok")) — Raynos
– Raynos, Commented Jun 20, 2011 at 15:08
Yes when I run the PHP it hangs because node isn't reaching the socket.on('end') code, but how do I fix this? — fire
– fire, Commented Jun 20, 2011 at 15:10
Yes that's what I thought but clearly not as it seems to hang. — fire
– fire, Commented Jun 20, 2011 at 15:36

fire · Accepted Answer · 2011-06-23 14:03:27Z

1

Set allowHalfOpen to true in net.createServer then use socket_shutdown($sock, 1) after write and socket_shutdown($sock, 0) after read.

answered Jun 23, 2011 at 14:03

fire

21.5k18 gold badges82 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Node JS read in buffered data

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related