C# If/else statement not working

Question

I have an if/else statement that is not working.

while (rdr.Read())
{
  string permission = rdr["Permission"].ToString();
  if (permission == "Exec")
  {
     Run my code
  }
  else
  {
     lblErrorStart.Visible = true;
  }
}

If Permission does equal Exec then everything works fine but (when stepping through the code) I have noticed that when Permission does not equal Exec, it does not trigger the Else. It just goes back to the while statement and stops. Let me know if I need to provide any more code.

Note: I only have Exec in the database. Everything else is null.

Try getting rid of the white-space in between the if statement's closing bracket and the else statement? — MoarCodePlz
– MoarCodePlz, Commented Jun 20, 2011 at 20:43
Do a rebuild of the entire solution and retest. It could be that the source code is out-of-sync with the binaries. — Brian Gideon
– Brian Gideon, Commented Jun 20, 2011 at 20:48
@MoarCodePlz: C# is not white space or indent sensitive (there are some exceptions, such as concatenating a string across newlines, but in this case it doesn't matter). — Ed Swangren
– Ed Swangren, Commented Jun 20, 2011 at 20:48
string permission = rdr["Permission"].ToString(); will throw a NullReferenceException if rdr["Permission"] is null. — mihi
– mihi, Commented Jun 20, 2011 at 20:49

Ed Swangren · Accepted Answer · 2011-06-20 20:57:47Z

4

I have noticed that when Permission does not equal Exec, it does not trigger the Else.

I have a very hard time believing that. Please show us the exact contents of permission when it does not equal "Exec".

Also realize that setting the label to visible will not update as soon as that code is executed. This is because you are not allowing the Windows Message Loop to process messages. So even though the Visible property is set to true, a WM_PAINT message is never processed (until your loop exits), so the appearance of your control will not change.

EDIT:

As Brian Gideon points out in a comment, your executable version may be out of sync with your code. Rebuild the entire project and try it again.

edited Jun 20, 2011 at 20:57

answered Jun 20, 2011 at 20:47

Ed Swangren

125k24 gold badges189 silver badges271 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DRapp · Accepted Answer · 2011-06-21 01:50:57Z

1

Sometimes when testing exact equality, you fail based on what you do NOT see... If your data is from a record set, or other structure and the actual value is NOT trimmed(), it will fail...

"Exec " == "Exec" will fail

Try

string permission = rdr["Permission"].ToString().Trim();

answered Jun 21, 2011 at 1:50

DRapp

48.3k13 gold badges80 silver badges149 bronze badges

Comments

Joe Mayo · Accepted Answer · 2020-10-19 15:34:41Z

0

Basically it's an if else statement like stated:

if(label1.Text == "True")
{
    label1.Forecolor = Color.Green;
}
else
{
    label1.Text = "ERROR!";
    label1.Forecolor = Color.Red;
}

Also, you can do multiple if statements and if none of them are relatively true you can have them all lead to the else statement.

edited Oct 19, 2020 at 15:34

Joe Mayo

7,5037 gold badges45 silver badges62 bronze badges

answered Oct 19, 2020 at 15:26

gbgjbj

1

Collectives™ on Stack Overflow

C# If/else statement not working

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related