try/catch not working and crashes app android

Question

I am inserting some data in my SQLite database android. I created an ArrayList of Content values. Below is my code.

try {
                SQLiteDatabase db = this.getWritableDatabase();
                db.beginTransaction();
                for (int i = 0; i < arrayListAudio.size(); i++) {
                    db.insert(TABLE_AUDIO_FILES, null, arrayListAudio.get(i));
                }
                for (int i = 0; i < arrayListText.size(); i++) {
                    db.insert(TABLE_TEXT_FILES, null, arrayListText.get(i));
                }
                db.setTransactionSuccessful();
                db.endTransaction();
                db.close();
                //arrayListText.clear();
                //arrayListAudio.clear();
} catch (SQLException e) {
       Log.d("vijaysee", e.getMessage());
}

It works but sometimes it does not work and crashes the application

My problem is that it crashes the application directly because try/catch not working. If there is any problem in the code then it should call catch but instead, it crashes the application. I think that there should be some change in catch brackets like catch(// some change){} . Please help me with this.

Martin Zeitler · Accepted Answer · 2020-10-10 02:36:51Z

1

You are catching a Java SQLException instead of an Android SQLiteException. And if you don't know what to catch, always try to catch an Exception. I'd rather worry about the SQL statement: INSERT INTO textFiles(null) VALUES (NULL) (which neither features columns nor values).

edited Oct 10, 2020 at 2:36

answered Oct 10, 2020 at 2:25

Martin Zeitler

79.6k20 gold badges170 silver badges244 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Vijay Over a year ago

does that mean, there are no columns in the table. Because I am deleting the tables and creating new each I open the activity.

Martin Zeitler Over a year ago

It means this is not valid INSERT statement. You'd need to insert at least 1 column and 1 value.

Vijay Over a year ago

ok it means i am inserting null values, so the problem is in the arrayList?

Martin Zeitler Over a year ago

Likely it is, but you're also explicitly passing null into the method. There's also Room, but for learning it, it is better when you'd first learn SQLite and then Room (it's an abstraction layer with object relational mapping, which completely abstracts that all away, but under the hood nevertheless uses SQLite).

Vijay · Accepted Answer · 2020-12-11 12:43:34Z

0

The reason why the app was crashing,

I was not using synchronisation (in threads)
I should catch using Exception class instead of specifying the exception.

edited Dec 11, 2020 at 12:43

answered Oct 10, 2020 at 9:09

Vijay

1,3881 gold badge12 silver badges23 bronze badges

Collectives™ on Stack Overflow

try/catch not working and crashes app android

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related