How to remove rows in data grid view where checkbox is checked?

Question

I am using C# .NET 2.0 Visual Studio 2005.

I am encountering weird issue.

There is a simple window form with just one DataGridView with column1 being checkbox (DataGridViewCheckboxColumn).

Then if the checkbox in the cell is checked, I want to remove the checked row.

Sound really simple but it does not remove all checked rows somehow, and I can't really figure why it is behaving in this way.

For instance, I have 5 rows and checked all checkbox in each row but it only removes 3 rows. Has anyone seen this before? Is this a bug or am I doing something wrong?

namespace WindowsApplication1
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        //when I click the button, all checked row should be removed
        private void button1_Click(object sender, EventArgs e)
        {
            foreach (DataGridViewRow row in dataGridView1.Rows)
            {
                if ((bool)row.Cells[0].Value)
                {
                    dataGridView1.Rows.Remove(row);
                }
            }
        }
    }
}

It is window form application and I don't see it in my project explore — Meow
– Meow, Commented Jun 22, 2011 at 12:28
I think running for loop in reverse is better and faster approach, because you won't extra list object to store toDelete rows and also you will need only one loop to do whole task. — love Computer science
– love Computer science, Commented Jun 22, 2011 at 15:21
@Charlie: thanks for the insight. Also another cause my grid deletion was behaving unexpectedly was I was not committing changes. myGrid.CommitEdit(DataGridViewDataErrorContexts.Commit); — Meow
– Meow, Commented Jun 23, 2011 at 6:45

love Computer science · Accepted Answer · 2011-06-22 13:04:11Z

14

its happening when one row is removed the rows count decrements too so if you put your code in for loop and run it in reverse it would work fine have a look:

for (int i = dataGridView1.Rows.Count -1; i >= 0 ; i--)
{
    if ((bool)dataGridView1.Rows[i].Cells[0].FormattedValue)
    {
        dataGridView1.Rows.RemoveAt(i);
    }
}

answered Jun 22, 2011 at 13:04

love Computer science

1,8284 gold badges20 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chen Kinnrot · Accepted Answer · 2011-06-22 12:20:46Z

6

You are modifiend a collection while iterating it.

Use a delete list and than remove the rows.

answered Jun 22, 2011 at 12:20

Chen Kinnrot

21.1k18 gold badges82 silver badges142 bronze badges

1 Comment

Meow Over a year ago

Thanks for the quick reply, could you explain in bit more detail? I don't find delete method...

Rajeev · Accepted Answer · 2011-06-22 13:05:01Z

6

You are modifying a collection while iterating it. Try like this

List<DataGridViewRow> toDelete = new List<DataGridViewRow>();
foreach (DataGridViewRow row in dataGridView1.Rows) {
    if (row.Cells[0].Value == true) {
        toDelete.Add(row);
    }
}
foreach (DataGridViewRow row in toDelete) {
    dataGridView1.Rows.Remove(row);
}

answered Jun 22, 2011 at 13:05

Rajeev

4,8992 gold badges28 silver badges35 bronze badges

1 Comment

user2430797 Over a year ago

Use casting in the if statement above: if ((bool)row.Cells[0].Value)

user1639870 · Accepted Answer · 2012-09-01 00:29:36Z

2

this solution gives a little error, I fixed adding 1 line :)

List<DataGridViewRow> toDelete = new List<DataGridViewRow>();

foreach (DataGridViewRow row in dataGridView1.Rows) 
{
  bool s = Convert.ToBoolean(row.Cells[0].Value) //added this line

  if (s == true) 
    {
        toDelete.Add(row);
    }
}

foreach (DataGridViewRow row in toDelete) 
{
    dataGridView1.Rows.Remove(row);
}

answered Sep 1, 2012 at 0:29

user1639870

212 bronze badges

Comments

bdparrish · Accepted Answer · 2011-06-22 12:24:47Z

1

@Chen Kinnrot, is absolutely on the money! You will always only delete n % 2 rows when you run your function, so if you have 10 rows, then you would delete 5, and 101 would be 51, etc. Iterate over the collection to find which checkboxes are check and then remove those rows. The better solution would be to attach an event to the checkbox that automatically runs when you click button1.

answered Jun 22, 2011 at 12:24

bdparrish

2,7844 gold badges40 silver badges62 bronze badges

Comments

user3663708 · Accepted Answer · 2014-05-22 06:35:57Z

ASPXPAGE:
<strong>Asp.Net : Delete Multiple Records form datagridview in one time<br />
        </strong>

        <asp:GridView ID="GridView1" runat="server" AutoGenerateColumns="False"
            BackColor="White" BorderColor="#CCCCCC" BorderStyle="None" BorderWidth="1px"
            CellPadding="4" EnableModelValidation="True" ForeColor="Black">
            <Columns>
                <asp:TemplateField>
                    <EditItemTemplate>
                        <asp:CheckBox ID="CheckBox1" runat="server" />
                    </EditItemTemplate>
                    <ItemTemplate>
                        <asp:CheckBox ID="CheckBox1" runat="server" />
                    </ItemTemplate>
                </asp:TemplateField>
                <asp:BoundField DataField="id" HeaderText="Sr No" />
                <asp:BoundField DataField="doc_name" HeaderText="Name" />
                <asp:BoundField DataField="doc_add" HeaderText="Address" />
                <asp:BoundField DataField="doc_mob" HeaderText="Mobile No" />
                <asp:BoundField DataField="doc_email" HeaderText="Email" />
            </Columns>
            <FooterStyle BackColor="#CCCC99" ForeColor="Black" />
            <HeaderStyle BackColor="#333333" Font-Bold="True" ForeColor="White" />
            <PagerStyle BackColor="White" ForeColor="Black" HorizontalAlign="Right" />
            <SelectedRowStyle BackColor="#CC3333" Font-Bold="True" ForeColor="White" />
        </asp:GridView>
        <br />
        <asp:Button ID="Button1" runat="server" Font-Size="12pt"
            onclick="Button1_Click1" Text="Delete" />
        <br />



Code Behind Page:
SqlConnection conn = new SqlConnection(@"server=server-pc; database=HMS; integrated security=true");
    protected void Page_Load(object sender, EventArgs e)
    {
        if (IsPostBack == false)
        {
            load_data();
        }
    }

   public void load_data()
    {
        SqlDataAdapter adp = new SqlDataAdapter("select * from doc_master", conn);
        DataSet ds = new DataSet();
        adp.Fill(ds);
        GridView1.DataSource = ds.Tables[0];
        GridView1.DataBind();
    }
   protected void Button1_Click1(object sender, EventArgs e)
   {
       CheckBox ch;
       for (int i = 0; i < GridView1.Rows.Count; i++)
       {
           ch = (CheckBox)GridView1.Rows[i].Cells[0].Controls[1];
           if (ch.Checked == true)
           {
      int id = Convert.ToInt32(GridView1.Rows[i].Cells[1].Text);
      SqlCommand cmd = new SqlCommand("delete from doc_master where ID=" + id + " ", conn);
      conn.Open();
      cmd.ExecuteNonQuery();
      conn.Close();
           }
       }

       load_data();
   }

For detailed code visit: http://www.gtuguide.com/2014/05/deleting-multiple-rows-in-gridview.html

Code · Accepted Answer · 2020-11-24 13:01:54Z

  protected void btnDelRow_Click(object sender, EventArgs e)
    {
        #region Delete Row from data list Grid On Behalf of checkbox from dyanamically added grid
        int ClSno = 0;  /*Use For Sitewise New Serial No*/
        foreach (DataListItem dst in dstBillDetails.Items)
        {
            ClSno = ClSno + 1;        
            Label lbl_SChkFlag = (Label)dst.FindControl("lblSChkFlag");        
            GridView Grid_B = (GridView)dst.FindControl("GridB");
            if (lbl_SChkFlag.Text == "0")
            {
                int Newbillflg = 0;/**If SiteCode Is Zero Then Usefull**/
                foreach (GridViewRow gvr in Grid_B.Rows)
                {
                    #region
                    Label lbl_grdId = (Label)gvr.FindControl("lblgrdId");
                    CheckBox chk_dstgrdlst = (CheckBox)gvr.FindControl("chkdstgrdlst");
                  
                    if (chk_dstgrdlst.Checked == true)
                    {
                        if (Grid_B.Rows.Count > 1)
                        {
                        
                            gvr.Style["display"] = "none";
                            lbl_grdId.Text = "1";                          
                        }
                        else
                        {/**When Gridview Row is Zero**/
                            Grid_B.Visible = false;
                            lbl_grdId.Text = "1";
                            /**When Gridview Row is Zero**/
                        }
                      
                    }
                    #endregion
                }
            }
        }
        #endregion
    }

Collectives™ on Stack Overflow

How to remove rows in data grid view where checkbox is checked?

7 Answers 7

Comments

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related