Reactive Form is always invalid when using dynamic patterns validation

Question

Reactive Form having dynamic patten validation is always invalid on first load. Even after I edit it still invalid.

This is happening only when I am adding dynamic pattern matching validation.

Here is my use case :

On UI there is table and edit button in last row
Initially No formcontrols are visible
User Clicks on edit button then form control gets appear.

Below is code

<form [formGroup]="data_form">
    <table class="table table-border">
        <thead>

            <th>
                name
            </th>
            <th>
                age
            </th>
            <th><button class="btn btn-primary ">Save</button></th>
        </thead>
        <tbody>
            <ng-container *ngFor='let item of data;let j = index'>
                <tr>
                    <ng-container *ngFor="let td of keys;let i = index">
                        <ng-container>

                            <td  *ngIf="td !=='isEditable'">
                                {{item[td]}}
                                <input   [formControlName]="getControlName(j,i)" *ngIf="item.isEditable" type="text" name="" id="">
          </td>

                        </ng-container>
                    </ng-container>

                    <td>
                        <button (click)="item.isEditable = true"> Edit</button>
                    </td>
                </tr>
            </ng-container>
        </tbody>
    </table>

</form>

ts code :

import { Component } from "@angular/core";
import { FormControl, FormGroup, Validators } from "@angular/forms";

@Component({
  selector: "my-app",
  templateUrl: "./app.component.html",
  styleUrls: ["./app.component.css"]
})
export class AppComponent {
  name = "Angular";
  data_form = new FormGroup({});
  public data;
  keys;

  ngOnInit() {
    this.data = [
      {
        name: "Sachin",
        age: 27,

        isEditable: false
      },
      {
        name: "Gopal",
        age: 27,

        isEditable: false
      },
      {
        name: "Pankaj",
        age: 24,

        isEditable: false
      }
    ];
    this.keys = Object.keys(this.data[0]);
    this.data.forEach((element, j) => {
      this.keys.forEach((k, i) => {
        this.data_form.addControl(
          "name_" + j + "_" + i,
          new FormControl(element[k], [Validators.required, Validators.pattern(/^[.\d]+$/)])
        );
      });
    });
  }

  log() {
    console.log(this.data);
  }

  getControlName(j, i) {
    return "name_" + j + "_" + i;
  }
}

Thanks in Advance.

EDIT:

Various Patterns that I have used :

Validators.pattern("^[a-zA-Z0-9 _/]+$")
Validators.pattern(/^[.\d]+$/)
Validators.pattern(/^(yes|no)$/i)
Validators.pattern(/^(0[1-9]|1[0-2])\/(0[1-9]|1\d|2\d|3[01])\/(19|20)\d{2}$/)

Owen Kelvin · Accepted Answer · 2020-10-17 19:03:21Z

1

The problem is actually because the pattern is being used for all the controls. I have refactored your code using FormArray and it seems your pattern work fine

Below is my approach TS File

  constructor(private fb: FormBuilder) {}
  patterns = [
    /^[.\d]+$/,
    /^(yes|no)$/i,
    /^[a-zA-Z0-9 _/]+$/,
    /^(0[1-9]|1[0-2])\/(0[1-9]|1\d|2\d|3[01])\/(19|20)\d{2}$/
  ];
  data = [
    {
      name: "Sachin",
      age: 27,
      isEditable: false
    },
    {
      name: "Gopal",
      age: 27,

      isEditable: false
    },
    {
      name: "Pankaj",
      age: 24,

      isEditable: false
    }
  ];
  keys = [...new Set(this.data.map(item => Object.keys(item)).flat())];
  keyPattern = this.keys.map(item => ({
    key: item,
    pattern: this.patterns.find(pattern =>
      this.data.every(i => pattern.test(i[item]))
    )
  }));
  data_form = this.fb.group({
    persons: this.fb.array(
      this.data.map(item =>
        this.fb.group(
          this.keyPattern.reduce(
            (prev, { key, pattern }) => ({
              ...prev,
              [key]: [
                item[key],
                [Validators.required, Validators.pattern(pattern)]
              ]
            }),
            {}
          )
        )
      )
    )
  });
  get persons(): FormArray {
    return this.data_form.get("persons") as FormArray;
  }

  toggleEdit(j) {
    const currentEditStatus = this.persons.controls[j].get("isEditable").value;
    this.persons.controls[j].get("isEditable").setValue(!currentEditStatus);
  }

HTML

<form [formGroup]="data_form">
    <table class="table table-border">
        <thead>
      <tr>
        <th> name </th>
            <th>age </th>
            <th><button class="btn btn-primary ">Save</button></th>
      </tr>
        </thead>
        <tbody formArrayName='persons'>
            <ng-container *ngFor='let item of persons.controls;let j = index'>
                <tr [formGroupName]='j'>
                    <ng-container *ngIf="!item.value.isEditable; else editable">
                        <td>{{ item.value.name }}</td>
                        <td>{{ item.value.age }}</td>
                    </ng-container>
                    <ng-template #editable>
                        <td><input formControlName='name'></td>
                        <td><input formControlName='age'></td>
                    </ng-template>
                    <td>
                        <button (click)="toggleEdit(j)">
              {{ !item.value.isEditable ? "Edit": "Cancel"}}
            </button>
                    </td>
                </tr>
            </ng-container>
        </tbody>
    </table>

</form>

See below fork Demo

edited Oct 17, 2020 at 19:03

answered Oct 17, 2020 at 14:38

Owen Kelvin

15.2k11 gold badges51 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

14 Comments

user1608841 Over a year ago

Validators.pattern("^[a-zA-Z0-9 _/]+$") I have this one also ..So here what I need to escape ?

user1608841 Over a year ago

okay let me update various patterns that I have used in question

Owen Kelvin Over a year ago

The only way I can think of is a reactive programming approach to avoid issues such as expressions changedAfterItWasChecked Error, will update my answer

Owen Kelvin Over a year ago

stackblitz.com/edit/angular-ngfor-ngmodel-table-eq4i81

Owen Kelvin Over a year ago

You can use the above as a starter

|

Collectives™ on Stack Overflow

Reactive Form is always invalid when using dynamic patterns validation

1 Answer 1

14 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

14 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related