PHP if statement dependent on value

Question

We currently have the following code which displays a link if a quotation is viewable:

        <td><?php echo $this->__($_quotation->getstatus()); ?></td>
        <td class="a-center">
            <?php if ($_quotation->isViewableByCustomer()): ?>
                    <a href="<?php echo $this->getViewUrl($_quotation) ?>"><?php echo $this->__('View Quotation') ?></a>
                <?php endif; ?>
        </td>

We're looking to show the link if the quotation status value equals Active or Expired but not Pending.

How should I change this code around to reflect this?

what is in the $_quotation function?

Naftali
– Naftali

2011-06-22 14:12:03 +00:00
Commented Jun 22, 2011 at 14:12 — Naftali
– Naftali, Commented Jun 22, 2011 at 14:12
Post the code from the isViewableByCustomer() function

Calvin Allen
– Calvin Allen

2011-06-22 14:12:38 +00:00
Commented Jun 22, 2011 at 14:12 — Calvin Allen
– Calvin Allen, Commented Jun 22, 2011 at 14:12

Michael Berkowski · Accepted Answer · 2011-06-22 15:35:38Z

2

I'm assuming you intend to show the status cell in any condition, and only link to it if Active or Expired. at least that's how I read your question.

Assuming the function $_quotation->getstatus() returns the strings "Active" or "Expired" before internationalization, just add something like this to the condition that displays the link:

 <td><?php echo $this->__($_quotation->getstatus()); ?></td>
 <td class="a-center">
     <?php if ($_quotation->isViewableByCustomer() && ($_quotation->getstatus() == "Active" || $_quotation->getstatus() == "Expired")): ?>
          <a href="<?php echo $this->getViewUrl($_quotation) ?>"><?php echo $this->__('View Quotation') ?></a>
     <?php endif; ?>
 </td>

EDIT According to comment below, isViewableByCustomer() is not relevant here, so try:

 <td><?php echo $this->__($_quotation->getstatus()); ?></td>
 <td class="a-center">
     <?php if ($_quotation->getstatus() == "Active" || $_quotation->getstatus() == "Expired"): ?>
          <a href="<?php echo $this->getViewUrl($_quotation) ?>"><?php echo $this->__('View Quotation') ?></a>
     <?php endif; ?>
 </td>

edited Jun 22, 2011 at 15:35

answered Jun 22, 2011 at 14:14

Michael Berkowski

271k47 gold badges452 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Vince P Over a year ago

This works with active and also doesn't show pending which is great but the expired link still doesn't show

Michael Berkowski Over a year ago

@Vince Pettit Then it's possible that getstatus() doesn't return exactly the string "Expired", but rather that string "Expired" is derived after internationalization __(). Find out exactly what getstatus() returns.

Vince P Over a year ago

We've come across the following: const STATUS_NEW = 'New'; const STATUS_CUSTOMER_REQUEST = 'Pending'; const STATUS_ACTIVE = 'Active'; const STATUS_EXPIRED = 'Expired';

Michael Berkowski Over a year ago

@Vince Pettit Somewhere where you can read the result on an expired record, just echo $_quotation->getstatus();. Also are you certain that isViewableByCustomer() is TRUE for expired records? If it is false, then the other side of the && won't be evaluated.

Vince P Over a year ago

Just realised the isViewableByCustomer() will only give a true value on Active. This function can be dropped from the code. We need it to display the link on a value from echo $_quotation->getstatus();

|

Mild Fuzz · Accepted Answer · 2011-06-22 14:18:30Z

0

   <?php if ($this->__($_quotation->getstatus() == "Active" || $this->__($_quotation->getstatus() == "Expired"){?><td><?php echo $this->__($_quotation->getstatus()); ?></td>
        <td class="a-center">
            <?php if ($_quotation->isViewableByCustomer()): ?>
                    <a href="<?php echo $this->getViewUrl($_quotation) ?>"><?php echo $this->__('View Quotation') ?></a>
                <?php endif; ?>
        </td>

edited Jun 22, 2011 at 14:18

answered Jun 22, 2011 at 14:13

Mild Fuzz

31.3k34 gold badges106 silver badges152 bronze badges

Collectives™ on Stack Overflow

PHP if statement dependent on value

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related