How to make Javascript timer work for variable parameter

Question

The Javascript timer event has this basic syntax:

var t=setTimeout("javascript statement",milliseconds);

I have this function that gets called onkeyup() for some text box. I want the numeric_value_search() function to be called after a certain amount of time, which is 5 seconds in this example.

The key line is the 5th line. I have four different ways that it might be written, each of which gives the specified error:

    timer=setTimeout(numeric_value_search(boundBox),5000);

ERROR: useless setTimeout call (missing quotes around argument?)

    timer=setTimeout("numeric_value_search(boundBox)",5000);

ERROR: boundBox is not defined

    timer=setTimeout("numeric_value_search("+boundBox+")",5000);

ERROR: missing ] after element list

    timer=setTimeout(numeric_value_search("+boundBox),5000);

ERROR: data is passed nicely and there are no explicit errors but the timer doesn't work

var timer;
function chk_me(boundBox){
console.info(boundBox.id);
    clearTimeout(timer);
//  --- timer code here ---   e.g. timer=setTimeout("numeric_value_search("+boundBox+")",5000);
}

ThiefMaster · Accepted Answer · 2011-06-23 07:59:45Z

3

As @kgiannakakis already said,

setTimeout(function() {
    numeric_value_search(boundBox);
}, 5000);

is the way to go.

The reason is simple: When using a string argument it's like using eval() which is usually evil. When passing a function however you not only avoid putting code inside a string (which breaks syntax highlighting and might require escape orgies) but also have the possibility of using a closure to access variables in the current context without embedding them into a string (which might lead to code injection if not done properly).

answered Jun 23, 2011 at 7:59

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ThiefMaster · Accepted Answer · 2011-06-23 07:57:31Z

2

Try this:

setTimeout(function() {
    numeric_value_search(boundBox);
}, 5000);

edited Jun 23, 2011 at 7:57

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

answered Jun 23, 2011 at 7:55

kgiannakakis

104k28 gold badges163 silver badges197 bronze badges

1 Comment

ThiefMaster Over a year ago

+1, this is the only way to use setTimeout which is both correct and clean.

Collectives™ on Stack Overflow

How to make Javascript timer work for variable parameter

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest