JQuery.each fails SOMETIMES

Question

Looping over a bunch of checkboxes SOMETIMES fails. The .each function is NOT entered when some or all boxes are checked so I get the "no checkboxes were checked" alert even though "checked" boxes exist.

$(document).ready(function() {
  $("#submitme").click(function() {
    var urls = [];
    $("#edit :checked").each(function() {
      var obj = {};
      obj.url = $(this).val();
      urls.push(obj);
    });
    if (0 < urls.length) {
      $.post('/myurl', {urls: JSON.stringify(urls)});
    }
    else {
      alert("no checkboxes were checked!");
    }
   });
});

<div id="edit">
  <input type="checkbox" name="first"  value="first_url"/>
  <input type="checkbox" name="second" value="second_url"/>
  <button id="submitme">submit</button>
</div>

jsFiddle Example

Do you get errors when this happens, or can you reproduce the problem? Threw this into jsFiddle and it doesn't seem to have failed once... — Björn
– Björn, Commented Jun 23, 2011 at 18:20
your code looks ok, and does work! see my fiddle: jsfiddle.net/heu96 do you have other code on the page that might be interfering? is this an exact copy of your code or did you retype it? edit: ninja'd i swear neal and bjorn's comments werent there while i started typing this — Patricia
– Patricia, Commented Jun 23, 2011 at 18:22
It is funny this works in fiddle b/c when you pull it to an actual page it doesn't parse. The if is messed up. — NullRef
– NullRef, Commented Jun 23, 2011 at 18:32
Having updated the syntax with JSLint not complaining anymore the problem still persists. — trajectory
– trajectory, Commented Jun 23, 2011 at 22:08

trajectory · Accepted Answer · 2011-07-05 12:49:46Z

1

No answer to the problem. The issue only exists in Opera so it's browser-related.

answered Jul 5, 2011 at 12:49

trajectory

1,4873 gold badges16 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Naftali · Accepted Answer · 2011-06-23 18:21:34Z

0

Seems to be working fine for me: http://jsfiddle.net/maniator/BFuaZ/

Make sure there are no javascript errors anywhere else in your code.

answered Jun 23, 2011 at 18:21

Naftali

147k41 gold badges247 silver badges304 bronze badges

Comments

Jean-Philippe Gire · Accepted Answer · 2011-06-23 18:22:37Z

0

Your selector should be $("#edit input:checked")

answered Jun 23, 2011 at 18:22

Jean-Philippe Gire

9017 silver badges15 bronze badges

Comments

NullRef · Accepted Answer · 2011-06-23 18:34:22Z

I think you have some syntax problems. Try:

$(document).ready(function() {
  $("#submitme").click(function() {
    var urls = new Array();
    $("#edit :checked").each(function() {
      var obj = new Object();
      obj.url = $(this).val();
      urls.push(obj);
    });

    if (0 < urls.length){
      $.post('/myurl', {urls: JSON.stringify(urls)});
    }else {
      alert("no checkboxes were checked!");
   }
   });
   });

If you look in jsfiddle at the JSLint output you get this

Error:

Problem at line 2 character 25: Use the array literal notation [].

var urls = new Array();

Problem at line 4 character 21: Use the object literal notation {}.

var obj = new Object();

Problem at line 9 character 7: Expected '{' and instead saw 'console'.

console.log(urls)

Problem at line 9 character 24: Missing semicolon.

console.log(urls)

Problem at line 11 character 7: Expected '{' and instead saw 'alert'.

alert("no checkboxes were checked!");

Implied global: $ 1,3,5, console 9, alert 11

Collectives™ on Stack Overflow

JQuery.each fails SOMETIMES

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related