Can I assign an enum based on an array of strings?

Question

I have a struct for a game I am building that looks like this:

using System;

public readonly struct Target
{
    public Target((int Min, int Max) range, string[] targetTypes)
    {
        Range = range;
        TargetType = ParseTypes(targetTypes);
    }
    public (int Min, int Max) Range { get; }
    public TargetTypes TargetType { get; }
    [Flags]
    public enum TargetTypes { None = 0, Self = 1, Enemy = 2, Player = 4, Character = 8, Area = 16 }
}

I would like to take all of the values in the string array and cast them into a single enum (not an array of enum values, which I believe is what is happening in the answer to this question).

The thing is a Target can have multiple types. I figured an enum was the best way to represent this, and also figured defining the enum inside the struct wasn't a terrible idea, but this could be an anti-pattern (coming from a JS background, be gentle!).

I like this whole enumeration types as bit flags thing, hence the numbering, that's what sent me down this path.

Yes, I control the inputs, so happy to hear why/how I should do this differently - thanks for your time!

If you do a string.join with a comma separator Enum.TryParse should work. learn.microsoft.com/en-us/dotnet/api/… see also stackoverflow.com/questions/2745320/… — asawyer
– asawyer, Commented Oct 30, 2020 at 1:57
Could you flesh that out into an example good sir? I am trying TargetType = Enum.TryParse(String.Join(",", targetTypes), out TargetType); without any luck — GrayedFox
– GrayedFox, Commented Oct 30, 2020 at 2:06
I was away for a bit and looks like @AnyViswan chimed in. Thanks! — asawyer
– asawyer, Commented Oct 30, 2020 at 2:28

Anu Viswan · Accepted Answer · 2020-10-30 02:14:15Z

1

You could use the following.

TargetType = (TargetTypes)Enum.Parse(typeof(TargetTypes),string.Join(",",targetTypes));

The second parameter of Enum.Parse accepts either a single value/constant representing the enum or a list of named constants or underlying values delimited by commas (,).

answered Oct 30, 2020 at 2:14

Anu Viswan

18.2k4 gold badges28 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

GrayedFox · Accepted Answer · 2020-10-30 02:20:03Z

0

Thank you @asawyer for pointing the way. I missed an important part of the documentation (always RFTM twice!):

Converts the string representation of the name or numeric value of one or more enumerated constants to an equivalent enumerated object.

There's no need for anything fancy here, Parse does the trick:

TargetType = (TargetTypes) Enum.Parse(typeof(TargetTypes), string.Join(",", targetTypes));

answered Oct 30, 2020 at 2:20

GrayedFox

2,59929 silver badges49 bronze badges

4 Comments

asawyer Over a year ago

fyi there's a generic version of this call - learn.microsoft.com/en-us/dotnet/api/… which would reduce your code to TargetType = Enum.Parse<TargetTypes>(string.Join(",", targetTypes)); No explicit casts or typeof needed.

asawyer Over a year ago

Honestly though since your input is just strings you have no guarantee the caller will provider the expected input which leaves you with two problems - What if the input can parse to an integer that is not a valid enumeration / flag combination? What if the input cannot be parsed at all? In the first case, if it can parse to the input to integer it will happily. Try with the value "123" instead of an enum value string. You'll get a Target back with the value 123, which is not defined in the enumeration. In the other case you'll get an ArgumentException thrown.

asawyer Over a year ago

-- continuing - If it where me, I'd simply have the constructor accept the enum value directly and push this task off to a dedicated enum parsing section, or into an load/save serialization type section. Why should a Target structure be involved in string parsing in the first place?

GrayedFox Over a year ago

All very good input, thank you! I will certainly consider defining the enum and doing that parsing somewhere dedicated!

Collectives™ on Stack Overflow

Can I assign an enum based on an array of strings?

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related