C#: Rethrow an exception from a variable while preserving stack trace

Question

In my codebase I have some retry functionality that stores an exception in a variable and at the end throws the exception in the variable. Imagine something like this

Exception exc = null;

while(condition){
   try {
      // stuff
   } catch (Exception e){
     exc = e;
   }
}

if (e != null){
   throw e;
}

Now, since this is a throw e statement and not a throw statement, the original stack trace is lost. Is there some way to do a rethrow that preserves the original stack trace, or will I need to restructure my code so I can use a throw statement?

But then I lose my Type info, so exception handlers that look at the type will not see the original type. — MrZarq
– MrZarq, Commented Nov 19, 2020 at 14:20
Wouldn't the original exception e contain the stack trace in its StackTrace property? — arconaut
– arconaut, Commented Nov 19, 2020 at 14:21

Peter Csala · Accepted Answer · 2020-11-19 15:06:48Z

8

That's where ExceptionDispatchInfo comes into play.
It resides inside the System.Runtime.ExceptionServices namespace.

class Program
{
    static void Main(string[] args)
    {
        ExceptionDispatchInfo edi = null;

        try
        {
            // stuff
            throw new Exception("A");
        }
        catch (Exception ex)
        {
            edi = ExceptionDispatchInfo.Capture(ex);
        }

        edi?.Throw();
    }
}

The output:

Unhandled exception. System.Exception: A
   at EDI_Demo.Program.Main(String[] args) in C:\Users\...\Program.cs:line 16
--- End of stack trace from previous location where exception was thrown ---
   at EDI_Demo.Program.Main(String[] args) in C:\Users\...\Program.cs:line 24

Line 16 is where throw new Exception("A"); is called
Line 24 is where edi?.Throw(); is called

edited Nov 19, 2020 at 15:06

answered Nov 19, 2020 at 14:32

Peter Csala

23.7k16 gold badges51 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C#: Rethrow an exception from a variable while preserving stack trace

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related