Problem with Brackets and Array Declaration

Question

So I'm working on my application and I'm simply trying to declare a new array of strings. For some reason it wants an extra bracket to close the class at the end (even though the brackets are fine), and also after "private String[] addSentences = new String[3];" if asks for "{" instead of ";". In other words it wants to close something...I don't get it. Maybe you guys can help.

package org.chinesetones.teacher;

import java.util.ArrayList;
import android.app.Activity;
import android.app.Dialog;
import android.content.Intent;
import android.os.Bundle;
import android.util.Log;
import android.view.Gravity;
import android.view.View;
import android.widget.Toast;
import android.view.View;
import android.view.View.OnClickListener;
import org.chinesetones.teacher.Sentence;

public class Game extends Activity implements OnClickListener {
private String[] addStrings = new String[3];
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.game);

// Setup button listeners...
View nextButton = findViewById(R.id.next_button);
nextButton.setOnClickListener(this);
View repeatButton = findViewById(R.id.repeat_button);
repeatButton.setOnClickListener(this);
}
public void onClick(View v){
    switch(v.getId()) {
    case R.id.next_button:
        giveSentence();
        break;
    case R.id.repeat_button:
        playSentence();
        break;
    }
}
private ArrayList<Sentence> sentences;
private String[] addSentences = new String[3];
addSentences[0] = "Hi";
addSentences[1] = "No";
addSentences[2] = "Yes";
}

giveSentence() and playSentence() have not been created yet. The errors are below.

Description Resource Path Location Type Syntax error on token ";", { expected after this token Game.java /ChineseTones/src/org/chinesetones/teacher line 39 Java Problem

Description Resource Path Location Type Syntax error, insert "}" to complete ClassBody Game.java /ChineseTones/src/org/chinesetones/teacher line 43 Java Problem

Thanks!

Bala R · Accepted Answer · 2011-06-28 18:59:40Z

1

You cannot initialize class field that way..

Change

private String[] addSentences = new String[3];
addSentences[0] = "Hi";
addSentences[1] = "No";
addSentences[2] = "Yes";

to

private String[] addSentences = {"Hi", "No", "Yes"};

The other option is to just do

private String[] addSentences = new String[3];

and initialize the array in the class constructor.

public Game()
{
   addSentences[0] = "Hi";
   addSentences[1] = "No";
   addSentences[2] = "Yes";
   ...
}

edited Jun 28, 2011 at 18:59

answered Jun 28, 2011 at 18:54

Bala R

109k23 gold badges203 silver badges212 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

byteWalrus Over a year ago

okay thank you, if I were to have around 500 indexes for this array though, would I have to manually add them like this or is there another way?

Bala R Over a year ago

@Wes see if my edited answer helps. You can init the array elements in the constructor.

aps Over a year ago

If the values (strings u are storing) are different(like in your case), then you would have to manually add them. If there is some form of formula which generates the value needs to be stored, then you can run a loop over array.length() and store them.

byteWalrus Over a year ago

My problem is they are sentences, and every sentence is different, so I guess my only option is to manually type out all the sentences to be used (probably more than 200). Can't think of another way. Thanks for the help.

Steve Brisk · Accepted Answer · 2011-06-28 19:02:28Z

0

You can only have declarations outside of methods. So your addSentence assignements

addSentences[0] = "Hi"; 
addSentences[1] = "No"; 
addSentences[2] = "Yes";

must either be in a method, constructor, or be part of the declaration.

For a small, statically-defined list like your's, you can do this:

 private String[] addSentences = {"Hi","No","Yes"};

If you had a larger initialization list you put that logic into your constructor.

public Game(){
   addSentences[0] = "Hi"; 
   addSentences[1] = "No"; 
   addSentences[2] = "Yes"; 
   ....
}

answered Jun 28, 2011 at 19:02

Steve Brisk

2,7932 gold badges17 silver badges14 bronze badges

2 Comments

TheOtherGuy Over a year ago

that's everything mentioned in the first answer. Did you not see it?

Steve Brisk Over a year ago

Wow, nearly identical. I must've missed it as I was typing my answer.

Collectives™ on Stack Overflow

Problem with Brackets and Array Declaration

2 Answers 2

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related