Nodejs axios http request loop

Question

I've a problem with Axios and foreach loop. My Api provider support only 5 contemporary call so I want call one by one but when execute this code the each body not wait the the finish call function and receive the error code 429. How can resolve this? thanks.

async function call(url) {
  var options = {
    method: 'GET',
    url: url,
    auth: {
      username: '*****',
      password: '*****'
    }
  };
  var response = await axios.request(options);
  print(response.data["Id"])
}

app.get('/save', async (req, res) => {
  var options = {
    method: 'GET',
    url: 'getListUser',
    auth: {
      username: '***',
      password: '***'
    }
  };
  var response = await axios.request(options);

  response.data["users"].forEach( async (val) => {
    console.log("ENTER");
    var url = 'getDetailUser' + val["id"];
    var res = await call(url); // <- How to wait finish this?
    console.log("EXIT")
  }, (err) => {
      console.log(err)
  })
  res.status(200).send("ok").end();
});

deerawan · Accepted Answer · 2020-12-04 19:07:08Z

2

FYI, Promise couldn't work with loop that involves callback ie forEach. Alternatively, you could use for of

try {
  for (const val of response.data['users']) {
    console.log("ENTER");
    var url = 'getDetailUser' + val["id"];
    var res = await call(url); 
    console.log("EXIT")
  }
} catch (error) {
  console.log(error)
}

answered Dec 4, 2020 at 19:07

deerawan

8,5035 gold badges46 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DevLoverUmar · Accepted Answer · 2020-12-04 09:24:24Z

1

I would say answer by @Ifaruki is correct with a minor change

await Promise.allSettled(response.data["users"].map(val => {
   var url = 'getDetailUser' + val["id"];
   return call(url); 
}))

For details check the difference. In some cases Promise.all might work but if any of the Promise fails, the whole result of Promise.all will be a rejection.

The code 429 can be resolved by looking at 429 Too Many Requests

edited Dec 4, 2020 at 9:24

answered Dec 4, 2020 at 8:18

DevLoverUmar

14.3k16 gold badges80 silver badges113 bronze badges

Comments

Ilijanovic · Accepted Answer · 2020-12-04 08:14:26Z

0

Promise.all() is the way

await Promise.all(response.data["users"].map(val => {
   var url = 'getDetailUser' + val["id"];
   return call(url); 
}))

edited Dec 4, 2020 at 8:14

answered Dec 4, 2020 at 8:08

Ilijanovic

15k4 gold badges29 silver badges63 bronze badges

Collectives™ on Stack Overflow

Nodejs axios http request loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related