ASP.NET Core DB-first Entity Framework Core can not auto increment primary key

Question

I have an ASP.NET Core project. I am using the database first approach with SQL Server and generated my models using EF Core.

I want the primary key to be auto incremented. Everything seems to work fine on the first entry in which it defaults my primary key (PimId) to 0. However, on the second insertion, the primary key remains 0.

My onModelCreate function

modelBuilder.Entity<ImportPim>(entity =>
        {
            entity.HasKey(e => e.PimId);
            entity.ToTable("Import_PIM");

            entity.Property(e => e.PimId)
                .HasColumnName("PIM_Id")
                .ValueGeneratedNever();

            entity.Property(e => e.CliId).HasColumnName("CLI_Id");

            entity.Property(e => e.PimAccountNumber)
                .HasColumnName("PIM_AccountNumber")
                .HasMaxLength(50)
                .IsUnicode(false);

This was generated by EF Core, I have tried changing ValueGeneratedNever() to ValueGeneratedOnAdd() but I get a saving error in SQL Server.

Any suggestions on how to do?

don't you need to add ValueGenerationOnAdd instead of ValueGeneratedNever — Nonik
– Nonik, Commented Dec 14, 2020 at 18:25
Does your table column have IDENTITY(1,1)? I generate models from databases, and usually the identity key property doesn't need to be specified in OnModelCreating — insane_developer
– insane_developer, Commented Dec 14, 2020 at 18:26
It is useless change it in OnModelCreating since you are using DB first. You need to set the primary key AUTO_INCREMENT in sql server, then re-generate the models. — mj1313
– mj1313, Commented Dec 15, 2020 at 6:44
@mj1313 an insane Thanks. It seems like the onModelCreating does not have any effect if you're using the DB first approach. — Megatron213
– Megatron213, Commented Dec 15, 2020 at 9:36

Majid Shahabfar · Accepted Answer · 2020-12-14 20:53:26Z

1

ValueGeneratedOnAdd() should works. If not, make sure that you set Identity for PimId in your table in SQL Server.

    entity.Property(e => e.PimId)
        .HasColumnName("PIM_Id")
        .ValueGeneratedOnAdd();

answered Dec 14, 2020 at 20:53

Majid Shahabfar

4,9672 gold badges32 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mehdi Diabi · Accepted Answer · 2020-12-14 18:30:21Z

0

You can set it as identity (Auto increment) like this:

modelBuilder.Entity<ImportPim>().Property(entity => entity.PimId).HasDatabaseGeneratedOption(DatabaseGeneratedOption.Identity);

answered Dec 14, 2020 at 18:30

Mehdi Diabi

611 gold badge2 silver badges5 bronze badges

Collectives™ on Stack Overflow

ASP.NET Core DB-first Entity Framework Core can not auto increment primary key

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related