Check string containing URL for "http://"

Question

I am trying to check the URL entered by the user, but I am fighting against some errors and warnings.

-(BOOL) textFieldShouldReturn:(UITextField *)textField {
    //check "http://"
    NSString *check = textField.text;
    NSString *searchString = @"http://";
    NSRange resultRange = [check rangeWithString:searchString];
    BOOL result = resultRange.location != NSNotFound;
    if (result) {
        NSURL *urlAddress = [NSURL URLWithString: textField.text];
    } else {
        NSString *good = [NSString stringWithFormat:@"http://%@", [textField text]];
        NSURL *urlAddress = [NSURL URLWithString: good];
    }
    // open url
    NSURLRequest *requestObject = [NSURLRequest requestWithURL:urlAddress];
}

They say:

NSString may not respond to -rangeWithString
Unused variable urlAddress in the condition "if … else" (for both)
urlAddress undeclared : in the URLRequest

Does anyone have any idea what to do?

Morten Fast · Accepted Answer · 2011-06-30 16:25:34Z

19

NSString responds to rangeOfString:, not rangeWithString:.

The variable urlAddress is declared both in the if statement, and in the else statement. That means it only lives in that scope. Once you leave the if/else statement, the variable is gone.

For a URL it's best if it begins with the scheme (like "http://"), and your code will gladly accept apple.http://.com as being valid.

You can use the hasPrefix: method instead, like this:

BOOL result = [[check lowercaseString] hasPrefix:@"http://"];
NSURL *urlAddress = nil;

if (result) {  
    urlAddress = [NSURL URLWithString: textField.text];
}
else {
    NSString *good = [NSString stringWithFormat:@"http://%@", [textField text]];
    urlAddress = [NSURL URLWithString: good];
}

NSURLRequest *requestObject = [NSURLRequest requestWithURL:urlAddress];

answered Jun 30, 2011 at 16:25

Morten Fast

6,32029 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Leszek Zarna · Accepted Answer · 2013-07-05 11:17:31Z

4

if ( [[url lowercaseString] hasPrefix:@"http://"] )
    return url;
else
    return [NSString stringWithFormat:@"http://%@", url];

answered Jul 5, 2013 at 11:17

Leszek Zarna

3,30728 silver badges28 bronze badges

Comments

Perception · Accepted Answer · 2011-06-30 16:22:51Z

1

I believe you want the rangeOfString method.

answered Jun 30, 2011 at 16:22

Perception

80.8k19 gold badges190 silver badges197 bronze badges

Comments

knuku · Accepted Answer · 2011-06-30 16:23:13Z

0

To get rid of your urlAddress warnings you should declare NSURL *urlAddress above if..else:

NSURL *urlAddress = nil;
if (result) {  
    urlAddress = [NSURL URLWithString: textField.text];    
} else {   
    NSString *good = [NSString stringWithFormat:@"http://%@", [textField text]];  
    urlAddress = [NSURL URLWithString: good];     
}

answered Jun 30, 2011 at 16:23

knuku

6,0921 gold badge37 silver badges44 bronze badges

Comments

Shivam Pokhriyal · Accepted Answer · 2018-09-20 11:09:52Z

0

Use this

NSString *stringUrl = url.absoluteString;

if ([stringUrl localizedCaseInsensitiveContainsString:@"your string"]) {
    //do something
}

It first converts url to string and then checks whether this url contains your string

answered Sep 20, 2018 at 11:09

Shivam Pokhriyal

1,10511 silver badges28 bronze badges

Comments

iPhoneDeveloper · Accepted Answer · 2017-10-10 04:50:01Z

-1

If you have a NSURL convert it to NSString with

   NSString stringURL = url.absoluteString

Then check whether this NSString contains http:// with this code

 [stringURL containsString: @"http://"]


    - (BOOL)containsString:(NSString *)string {
    return [self containsString:string caseSensitive:NO];
}

- (BOOL)containsString:(NSString*)string caseSensitive:(BOOL)caseSensitive {
    BOOL contains = NO;
    if (![NSString isNilOrEmpty:self] && ![NSString isNilOrEmpty:string]) {
        NSRange range;
        if (!caseSensitive) {
            range =  [self rangeOfString:string options:NSCaseInsensitiveSearch];
        } else {
            range =  [self rangeOfString:string];
        }
        contains = (range.location != NSNotFound);
    }

    return contains;
}

answered Oct 10, 2017 at 4:50

iPhoneDeveloper

9921 gold badge15 silver badges23 bronze badges

1 Comment

Shivam Pokhriyal Over a year ago

Much better to use [stringUrl localizedCaseInsensitiveContainsString:@"gif"]

Collectives™ on Stack Overflow

Check string containing URL for "http://"

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related